From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, linux-pwm@vger.kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells
Date: Mon, 6 Nov 2023 11:48:42 +0100 [thread overview]
Message-ID: <20231106104842.ooxzow6slw575xrs@pengutronix.de> (raw)
In-Reply-To: <20231106095205.231210-3-alexander.stein@ew.tq-group.com>
[-- Attachment #1: Type: text/plain, Size: 2406 bytes --]
Hello,
[again Cc -= Philippe Schenker]
On Mon, Nov 06, 2023 at 10:52:04AM +0100, Alexander Stein wrote:
> i.MX8QM/QXP supports inverted PWM output, thus #pwm-cells needs to be set
> to 3.
>
> Fixes: a05c329644d81 ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi
> index 49ad3413db948..7e510b21bbac5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi
> @@ -29,7 +29,7 @@ lsio_pwm0: pwm@5d000000 {
> <&pwm0_lpcg 1>;
> assigned-clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>;
> assigned-clock-rates = <24000000>;
> - #pwm-cells = <2>;
> + #pwm-cells = <3>;
> interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> @@ -42,7 +42,7 @@ lsio_pwm1: pwm@5d010000 {
> <&pwm1_lpcg 1>;
> assigned-clocks = <&clk IMX_SC_R_PWM_1 IMX_SC_PM_CLK_PER>;
> assigned-clock-rates = <24000000>;
> - #pwm-cells = <2>;
> + #pwm-cells = <3>;
> interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> @@ -55,7 +55,7 @@ lsio_pwm2: pwm@5d020000 {
> <&pwm2_lpcg 1>;
> assigned-clocks = <&clk IMX_SC_R_PWM_2 IMX_SC_PM_CLK_PER>;
> assigned-clock-rates = <24000000>;
> - #pwm-cells = <2>;
> + #pwm-cells = <3>;
> interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> @@ -68,7 +68,7 @@ lsio_pwm3: pwm@5d030000 {
> <&pwm3_lpcg 1>;
> assigned-clocks = <&clk IMX_SC_R_PWM_3 IMX_SC_PM_CLK_PER>;
> assigned-clock-rates = <24000000>;
> - #pwm-cells = <2>;
> + #pwm-cells = <3>;
> interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
Even without patch #1 this is a good change. There are no usages of the
lsio_pwm* handles as of today's next. So no consumers need adaption.
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-11-06 10:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 9:52 [PATCH 0/3] imx8qm/imx8qxp: Support for inverted PWM Alexander Stein
2023-11-06 9:52 ` [PATCH 1/3] dt-bindings: pwm: imx-pwm: Add constraints for #pwm-cells Alexander Stein
2023-11-06 10:36 ` Uwe Kleine-König
2023-11-06 10:49 ` Alexander Stein
2023-11-06 11:02 ` Uwe Kleine-König
2023-12-05 12:36 ` Shawn Guo
2023-12-05 12:37 ` Shawn Guo
2023-11-06 9:52 ` [PATCH 2/3] arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells Alexander Stein
2023-11-06 10:48 ` Uwe Kleine-König [this message]
2023-11-06 9:52 ` [PATCH 3/3] arm64: dts: freescale: imx8-ss-dma: " Alexander Stein
2023-11-06 10:49 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106104842.ooxzow6slw575xrs@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).