From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: pwm: add support for MC33XS2410
Date: Thu, 29 Feb 2024 08:45:25 +0100 [thread overview]
Message-ID: <2ad77fdf-ab8d-43b1-be19-304c9f983f3a@linaro.org> (raw)
In-Reply-To: <20240228154129.GA749753@debian>
On 28/02/2024 16:41, Dimitri Fedrau wrote:
>>> + maxItems: 5
>>> +
>>> + pwm-names:
>>> + items:
>>> + - const: di0
>>> + - const: di1
>>> + - const: di2
>>> + - const: di3
>>> + - const: ext_clk
>>
>> Aren't these clocks?
>>
> di0-3 are PWM input signals which are translated to output voltage "vpwr".
> ext_clk is described as PWM clock in the datasheet. Didn't used it, just
> mentioned it here for completeness.
Then it looks more like a clock, so clocks: property.
>>> +
>>> + vdd-supply:
>>> + description:
>>> + Logic supply voltage
>>> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-29 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 13:32 [PATCH 0/3] pwm: add support for NXPs high-side switch MC33XS2410 Dimitri Fedrau
2024-02-28 13:32 ` [PATCH 1/3] dt-bindings: pwm: add support for MC33XS2410 Dimitri Fedrau
2024-02-28 13:59 ` Krzysztof Kozlowski
2024-02-28 15:41 ` Dimitri Fedrau
2024-02-29 7:45 ` Krzysztof Kozlowski [this message]
2024-02-28 13:32 ` [PATCH 2/3] pwm: add support for NXPs high-side switch MC33XS2410 Dimitri Fedrau
2024-02-28 13:32 ` [PATCH 3/3] pwm: mc33xs2410: add support for direct inputs Dimitri Fedrau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ad77fdf-ab8d-43b1-be19-304c9f983f3a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).