From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>, Rob Herring <robh@kernel.org>
Cc: "jdelvare@suse.com" <jdelvare@suse.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"corbet@lwn.net" <corbet@lwn.net>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"naresh.solanki@9elements.com" <naresh.solanki@9elements.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
BMC-SW <BMC-SW@aspeedtech.com>,
"patrick@stwcx.xyz" <patrick@stwcx.xyz>
Subject: Re: [PATCH v12 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control
Date: Mon, 15 Jan 2024 08:56:27 +0100 [thread overview]
Message-ID: <40210196-3852-4c8b-94e6-e744890f003f@linaro.org> (raw)
In-Reply-To: <OSQPR06MB725208AEF8779B0BC971DFF48B6C2@OSQPR06MB7252.apcprd06.prod.outlook.com>
On 15/01/2024 08:05, Billy Tsai wrote:
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/clock/aspeed-clock.h>
>>> + pwm_tach: pwm-tach-controller@1e610000 {
>>> + compatible = "aspeed,ast2600-pwm-tach";
>>> + reg = <0x1e610000 0x100>;
>>> + clocks = <&syscon ASPEED_CLK_AHB>;
>>> + resets = <&syscon ASPEED_RESET_PWM>;
>>> + #pwm-cells = <3>;
>>> +
>>> + fan-0 {
>>> + tach-ch = /bits/ 8 <0x0>;
>>> + };
>>> +
>>> + fan-1 {
>>> + tach-ch = /bits/ 8 <0x1 0x2>;
>>> + };
>
>> NAK on this based on how you are using pwm-fan in v10 discussion. See my
>> comments there.
>
> Okay, I will merge everything from the pwm-fan0 node into the fan-0 node
> and add the 'simple-bus' to the compatible string of the pwm_tach node.
What simple-bus has anything to do with it? This is not a bus. Just to
remind: we talk about bindings, not driver.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-15 7:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 7:43 [PATCH v12 0/3] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2024-01-08 7:43 ` [PATCH v12 1/3] dt-bindings: hwmon: fan: Add fan binding to schema Billy Tsai
2024-01-13 1:55 ` Rob Herring
2024-01-15 9:25 ` Krzysztof Kozlowski
2024-01-16 3:09 ` Billy Tsai
2024-01-08 7:43 ` [PATCH v12 2/3] dt-bindings: hwmon: Support Aspeed g6 PWM TACH Control Billy Tsai
2024-01-13 1:55 ` Rob Herring
2024-01-15 7:05 ` Billy Tsai
2024-01-15 7:56 ` Krzysztof Kozlowski [this message]
2024-01-15 8:43 ` Billy Tsai
2024-01-15 9:26 ` Krzysztof Kozlowski
2024-01-08 7:43 ` [PATCH v12 3/3] hwmon: (aspeed-g6-pwm-tacho): Support for ASPEED g6 PWM/Fan tach Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40210196-3852-4c8b-94e6-e744890f003f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
--cc=p.zabel@pengutronix.de \
--cc=patrick@stwcx.xyz \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).