From: George Stark <gnstark@salutedevices.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: <neil.armstrong@linaro.org>, <khilman@baylibre.com>,
<jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>,
<thierry.reding@gmail.com>, <hkallweit1@gmail.com>,
<linux-pwm@vger.kernel.org>, <linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kernel@salutedevices.com>,
Dmitry Rokosov <ddrokosov@salutedevices.com>
Subject: Re: [PATCH 1/2] pwm: meson: drop unneeded check in get_state callback
Date: Wed, 24 Apr 2024 10:57:34 +0300 [thread overview]
Message-ID: <6d34b236-4067-42bf-a6f7-d2f3b3270e3b@salutedevices.com> (raw)
In-Reply-To: <wkn6ybnnlco7vrqbpclfxaajt5cvywpr633au7qcr6vpjihabq@kb7q6y4khh2k>
Hello Uwe
Thanks for the review
On 4/24/24 10:19, Uwe Kleine-König wrote:
> Hello George,
>
> On Tue, Apr 23, 2024 at 07:13:55PM +0300, George Stark wrote:
>> Drop checking state argument for null pointer in meson_pwm_get_state()
>> due to it is called only from pwm core with always valid arguments.
>>
>> Fixes: 211ed630753d ("pwm: Add support for Meson PWM Controller")
>> Signed-off-by: George Stark <gnstark@salutedevices.com>
>> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
>
> I'd apply this one with the following changes if you agree:
>
> - capitalize "drop" in the Subject line
> - s/get_state/.get_state()/
> - make "null" all caps (i.e. "NULL")
> - swap the order of Signed-off-by lines to have yours last.
>
> Alternatively send it in a v2 together with addressing the comment in
> the second patch.
I agree with the proposed changes and
I'll clean it up after myself in v2
> Best regards
> Uwe
>
--
Best regards
George
next prev parent reply other threads:[~2024-04-24 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 16:13 [PATCH 0/2] meson pwm small fixes George Stark
2024-04-23 16:13 ` [PATCH 1/2] pwm: meson: drop unneeded check in get_state callback George Stark
2024-04-24 7:19 ` Uwe Kleine-König
2024-04-24 7:57 ` George Stark [this message]
2024-04-23 16:13 ` [PATCH 2/2] pwm: meson: add check for error from clk_round_rate() George Stark
2024-04-24 7:13 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d34b236-4067-42bf-a6f7-d2f3b3270e3b@salutedevices.com \
--to=gnstark@salutedevices.com \
--cc=ddrokosov@salutedevices.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@salutedevices.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).