From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Sean Young <sean@mess.org>
Cc: Trevor Gamblin <tgamblin@baylibre.com>,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
michael.hennerich@analog.com, nuno.sa@analog.com,
devicetree@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] pwm: Add driver for AXI PWM generator
Date: Tue, 16 Jan 2024 13:49:12 +0100 [thread overview]
Message-ID: <7cycugkqw3sew7qvr3ltntg7newzqbccl3xy5je5jgnrg7d6e5@nex2hngeqtlu> (raw)
In-Reply-To: <ZaY-FjeRV2qPL0wz@gofer.mess.org>
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
Hello,
On Tue, Jan 16, 2024 at 08:28:06AM +0000, Sean Young wrote:
> On Mon, Jan 15, 2024 at 10:18:04PM +0100, Uwe Kleine-König wrote:
> > On Mon, Jan 15, 2024 at 03:12:21PM -0500, Trevor Gamblin wrote:
> > > + pwm->chip.dev = &pdev->dev;
> > > + pwm->chip.ops = &axi_pwmgen_pwm_ops;
>
> In that case pwm->chip.atomic = true; can be set too (although this should
> be tested with CONFIG_DEBUG_ATOMIC_SLEEP and CONFIG_PWM_DEBUG).
Oh indeed. Good catch.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-01-16 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 20:12 [PATCH 0/2] pwm: add axi-pwm-gen driver Trevor Gamblin
2024-01-15 20:12 ` [PATCH 1/2] dt-bindings: pwm: Add bindings for AXI PWM generator Trevor Gamblin
2024-01-16 7:38 ` Krzysztof Kozlowski
2024-01-15 20:12 ` [PATCH 2/2] pwm: Add driver " Trevor Gamblin
2024-01-15 21:18 ` Uwe Kleine-König
2024-01-16 8:28 ` Sean Young
2024-01-16 12:49 ` Uwe Kleine-König [this message]
2024-01-17 12:51 ` Trevor Gamblin
2024-01-17 14:18 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cycugkqw3sew7qvr3ltntg7newzqbccl3xy5je5jgnrg7d6e5@nex2hngeqtlu \
--to=u.kleine-koenig@pengutronix.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
--cc=tgamblin@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).