From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-pwm@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 0/4] pwm: Simplify drivers with of_pwm_n_cells = 3
Date: Tue, 25 May 2021 18:24:33 +0200 [thread overview]
Message-ID: <YK0kwVVTX86f8lzc@orome.fritz.box> (raw)
In-Reply-To: <20210424210718.2787498-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2503 bytes --]
On Sat, Apr 24, 2021 at 11:07:14PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> this is v2 of the series sent earlier starting with Message-Id:
> 20210315111124.2475274-1-u.kleine-koenig@pengutronix.de. (See
> https://lore.kernel.org/r/20210315111124.2475274-1-u.kleine-koenig@pengutronix.de).
>
> The only change is using
>
> if (pc->of_pwm_n_cells >= 3) {
> if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED)
> pwm->args.polarity = PWM_POLARITY_INVERSED;
> }
>
> instead of
>
> if (pc->of_pwm_n_cells >= 3 && args->args_count > 2 &&
> args->args[2] & PWM_POLARITY_INVERTED)
> pwm->args.polarity = PWM_POLARITY_INVERSED;
>
> in the first patch which is semantically equivalent but Thierry likes it
> better. This targets to go into next early after v5.13-rc1 so that it
> gets proper testing before entering mainline.
>
> Best regards
> Uwe
>
> Uwe Kleine-König (4):
> pwm: Make of_pwm_xlate_with_flags() work with #pwm-cells = <2>
> pwm: Drop of_pwm_simple_xlate() in favour of of_pwm_xlate_with_flags()
> pwm: Autodetect default value for of_pwm_n_cells from device tree
> pwm: Simplify all drivers with explicit of_pwm_n_cells = 3
>
> drivers/pwm/core.c | 44 ++++++++++------------------------
> drivers/pwm/pwm-atmel-hlcdc.c | 2 --
> drivers/pwm/pwm-atmel-tcb.c | 2 --
> drivers/pwm/pwm-atmel.c | 2 --
> drivers/pwm/pwm-bcm-iproc.c | 2 --
> drivers/pwm/pwm-bcm-kona.c | 2 --
> drivers/pwm/pwm-bcm2835.c | 2 --
> drivers/pwm/pwm-berlin.c | 2 --
> drivers/pwm/pwm-fsl-ftm.c | 2 --
> drivers/pwm/pwm-hibvt.c | 2 --
> drivers/pwm/pwm-imx-tpm.c | 2 --
> drivers/pwm/pwm-imx27.c | 3 ---
> drivers/pwm/pwm-jz4740.c | 2 --
> drivers/pwm/pwm-lpc18xx-sct.c | 2 --
> drivers/pwm/pwm-meson.c | 2 --
> drivers/pwm/pwm-mxs.c | 2 --
> drivers/pwm/pwm-omap-dmtimer.c | 2 --
> drivers/pwm/pwm-renesas-tpu.c | 2 --
> drivers/pwm/pwm-rockchip.c | 5 ----
> drivers/pwm/pwm-samsung.c | 3 ---
> drivers/pwm/pwm-sifive.c | 2 --
> drivers/pwm/pwm-stm32-lp.c | 2 --
> drivers/pwm/pwm-stm32.c | 2 --
> drivers/pwm/pwm-sun4i.c | 2 --
> drivers/pwm/pwm-tiecap.c | 2 --
> drivers/pwm/pwm-tiehrpwm.c | 2 --
> drivers/pwm/pwm-vt8500.c | 2 --
> 27 files changed, 13 insertions(+), 88 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-05-25 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 21:07 [PATCH v2 0/4] pwm: Simplify drivers with of_pwm_n_cells = 3 Uwe Kleine-König
2021-04-24 21:07 ` [PATCH v2 1/4] pwm: Make of_pwm_xlate_with_flags() work with #pwm-cells = <2> Uwe Kleine-König
2021-04-24 21:07 ` [PATCH v2 2/4] pwm: Drop of_pwm_simple_xlate() in favour of of_pwm_xlate_with_flags() Uwe Kleine-König
2021-04-24 21:07 ` [PATCH v2 3/4] pwm: Autodetect default value for of_pwm_n_cells from device tree Uwe Kleine-König
2021-04-24 21:07 ` [PATCH v2 4/4] pwm: Simplify all drivers with explicit of_pwm_n_cells = 3 Uwe Kleine-König
2021-05-25 16:24 ` Thierry Reding [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-10 14:06 [PATCH v2 0/4] pwm: Simplify drivers with " Uwe Kleine-König
2021-05-10 14:48 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK0kwVVTX86f8lzc@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).