From: JiSheng Teoh <jisheng.teoh@starfivetech.com>
To: "Conor Dooley" <conor.dooley@microchip.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Conor Dooley <conor+dt@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
William Qiu <william.qiu@starfivetech.com>,
Leyfoon Tan <leyfoon.tan@starfivetech.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: RE: [PATCH] dt-bindings: pwm: opencores: Add compatible for StarFive JH8100
Date: Tue, 27 Feb 2024 02:01:11 +0000 [thread overview]
Message-ID: <ZQ0PR01MB11608585A27081C61ACB93F8EB59A@ZQ0PR01MB1160.CHNPR01.prod.partner.outlook.cn> (raw)
In-Reply-To: <20240226-greasily-balcony-cee5014f5b8b@wendy>
> On Mon, Feb 26, 2024 at 09:11:23AM +0100, Uwe Kleine-König wrote:
> > Hello,
> >
> > On Mon, Feb 26, 2024 at 11:39:45AM +0800, Ji Sheng Teoh wrote:
> > > StarFive JH8100 uses the same OpenCores PWM controller as JH7110.
> > > Mark JH8100 as compatible to the OpenCores PWM controller.
> > >
> > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> > >
> > > ---
> > >
> > > This patch depends on patch [1] ("dt-bindings: pwm: Add bindings for
> > > OpenCores PWM Controller") in Conor's riscv-dt-for-next branch.
> > > [1]
> > > https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/comm
> > > it/?h=riscv-dt-for-next&id=2529085831b01fcd02ff58ab4e2596d3b31bcf80
> >
> > I recommend to make use of git format-patch's --base parameter to
> > additionally(!) make this information available to the build bots.
>
> I like the "additionally" :)
Alright, I will take note of that. Thanks
> >
> > Looks fine to me.
> >
> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > Coner: If you're happy with this patch, please apply it in the same
> > way as the initial OpenCores PWM Controller binding patch.
>
> Ye, I can do. Although, I suppose this is an example of why the driver maintainers applying the bindings is preferred, even if the driver
> patch itself isn't ready or there is no driver patch.
>
> Cheers,
> Conor.
next prev parent reply other threads:[~2024-02-27 2:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 3:39 [PATCH] dt-bindings: pwm: opencores: Add compatible for StarFive JH8100 Ji Sheng Teoh
2024-02-26 8:11 ` Uwe Kleine-König
2024-02-26 10:00 ` Conor Dooley
2024-02-27 2:01 ` JiSheng Teoh [this message]
2024-02-26 10:06 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ0PR01MB11608585A27081C61ACB93F8EB59A@ZQ0PR01MB1160.CHNPR01.prod.partner.outlook.cn \
--to=jisheng.teoh@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=william.qiu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).