From: Jisheng Zhang <jszhang@kernel.org>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Guo Ren" <guoren@kernel.org>, "Fu Wei" <wefu@redhat.com>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 0/2] pwm: add driver for T-THEAD TH1520 SoC
Date: Mon, 6 Nov 2023 22:49:33 +0800 [thread overview]
Message-ID: <ZUj8/fhitNf8fRMf@xhacker> (raw)
In-Reply-To: <20231005130519.3864-1-jszhang@kernel.org>
On Thu, Oct 05, 2023 at 09:05:17PM +0800, Jisheng Zhang wrote:
> T-HEAD SoCs such as the TH1520 contain a PWM controller used to
> control the LCD backlight, fan and so on. Add the PWM driver support
> for it.
>
> Since the clk part isn't mainlined, so SoC dts(i) changes are not
> included in this series. However, it can be tested by using fixed-clock.
>
> since v2:
> - collect Reviewed-by tag
> - add CTRL_ prefix for THEAD_PWM_CTRL register bit macros
> - use pm_runtime_resume_and_get() instead of pm_runtime_get_sync() and
> check its return value.
> - remove unnecessary casts
> - call pm_runtime_put_sync() when pwm channel is disabled
> - use devm_pm_runtime_enable() and then drop .remove()
> - properly consider if pwm is programmed by bootloader or other
> pre-linux env.
> - simplify thead_pwm_runtime_resume() code as Uwe suggested
> - bool ever_started -> u8 channel_ever_started since we have 6 channels
> - use 3 for #pwm-cells
>
> since v1:
> - update commit msg and yaml filename to address Conor's comment
> - use devm_clk_get_enabled() and devm_pwmchip_add()
> - implement .get_state()
> - properly handle overflow
> - introduce thead_pwm_from_chip() inline function
> - document Limitations
> - address pm_runtime_get/put pingpong comment
>
>
> Jisheng Zhang (2):
> dt-bindings: pwm: Add T-HEAD PWM controller
> pwm: add T-HEAD PWM driver
Hi Thierry, Uwe,
Kind ping, is there any chance for this series to be merged for v6.7?
Thanks
>
> .../bindings/pwm/thead,th1520-pwm.yaml | 44 +++
> drivers/pwm/Kconfig | 11 +
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-thead.c | 270 ++++++++++++++++++
> 4 files changed, 326 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/thead,th1520-pwm.yaml
> create mode 100644 drivers/pwm/pwm-thead.c
>
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-11-06 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 13:05 [PATCH v3 0/2] pwm: add driver for T-THEAD TH1520 SoC Jisheng Zhang
2023-10-05 13:05 ` [PATCH v3 1/2] dt-bindings: pwm: Add T-HEAD PWM controller Jisheng Zhang
2023-11-13 21:37 ` Uwe Kleine-König
2023-10-05 13:05 ` [PATCH v3 2/2] pwm: add T-HEAD PWM driver Jisheng Zhang
2023-11-13 21:56 ` Uwe Kleine-König
2024-04-15 11:48 ` Thomas Bonnefille
2023-11-06 14:49 ` Jisheng Zhang [this message]
2023-11-06 15:43 ` [PATCH v3 0/2] pwm: add driver for T-THEAD TH1520 SoC Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUj8/fhitNf8fRMf@xhacker \
--to=jszhang@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).