From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Paul Cercueil <paul@crapouillou.net>,
linux-mips@vger.kernel.org, linux-pwm@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] pwm: jz4740: Add trailing \n to error messages
Date: Fri, 24 Nov 2023 13:43:01 +0100 [thread overview]
Message-ID: <ZWCaVQXjlBHMW8Jf@orome.fritz.box> (raw)
In-Reply-To: <20231123083322.405390-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]
On Thu, Nov 23, 2023 at 09:33:23AM +0100, Uwe Kleine-König wrote:
> Error messages are supposed to end in \n. Add the line terminator to the
> two error messages that lack this.
>
> Suggested-by: Paul Cercueil <paul@crapouillou.net>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this was noticed by Paul in
> https://lore.kernel.org/linux-pwm/ba21c20b20364a39d5ffff81dac8bd300a746dbb.camel@crapouillou.net.
> Instead of sneaking this into a patch that probably won't get applied
> quickly, make this explicit.
>
> I based it on top of my PR that can be found at
> https://lore.kernel.org/linux-pwm/20231121112029.gyv3gqirlycysyr4@pengutronix.de,
> but applies just fine to v6.7-rc1.
>
> If you want a fixes-line, that would be:
>
> Fixes: 485b56f08f33 ("pwm: jz4740: Improve algorithm of clock calculation")
>
> for the first hunk and
>
> Fixes: ce1f9cece057 ("pwm: jz4740: Use clocks from TCU driver")
>
> for the second. If this is backported to something before
> v5.10-rc1~57^2~11, there is another instance with a missing \n.
>
> Best regards
> Uwe
My recollection is that the newlines aren't strictly required because
printk will typically insert them itself (unless KERN_CONT is involved
at some point). So I don't think this really fixes anything, but I'm
willing to pick this up for consistency.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-11-24 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 8:33 [PATCH] pwm: jz4740: Add trailing \n to error messages Uwe Kleine-König
2023-11-24 12:43 ` Thierry Reding [this message]
2023-12-04 17:12 ` Uwe Kleine-König
2023-11-28 16:59 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWCaVQXjlBHMW8Jf@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).