From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11] pwm: bcm2835: Allow PWM driver to be used in atomic context
Date: Fri, 22 Dec 2023 10:37:02 +0000 [thread overview]
Message-ID: <ZYVmzrRwgVOGinmy@gofer.mess.org> (raw)
In-Reply-To: <fuku3b5ur6y4k4refd3vmeoenzjo6mwe3b3gtel34rhhhtvnsa@w4uktgbqsc3w>
On Fri, Dec 22, 2023 at 11:30:47AM +0100, Uwe Kleine-König wrote:
> Hello Sean,
>
> On Wed, Dec 20, 2023 at 02:24:25PM +0000, Sean Young wrote:
> > @@ -151,8 +153,26 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
> > return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
> > "clock not found\n");
> >
> > + ret = clk_rate_exclusive_get(pc->clk);
> > + if (ret)
> > + return dev_err_probe(&pdev->dev, ret,
> > + "fail to get exclusive rate\n");
> > +
> > + ret = devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_put,
> > + pc->clk);
> > + if (ret) {
> > + clk_rate_exclusive_put(pc->clk);
>
> That clk_rate_exclusive_put() is wrong. If devm_add_action_or_reset()
> fails that is already cared for.
Yes, you're right. I missed that - should've checked.
> Given that Thierry already applied this patch, getting this fixed in a
> timely manner would be good.
I'll send out a patch shortly, thanks for catching.
Sean
prev parent reply other threads:[~2023-12-22 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 14:24 [PATCH v11] pwm: bcm2835: Allow PWM driver to be used in atomic context Sean Young
2023-12-20 16:06 ` Thierry Reding
2023-12-22 10:30 ` Uwe Kleine-König
2023-12-22 10:37 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYVmzrRwgVOGinmy@gofer.mess.org \
--to=sean@mess.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).