From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lee Jones <lee@kernel.org>
Cc: linux-pwm@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
kernel@pengutronix.de
Subject: Re: [PATCH] backlight: lp8788: Drop support for platform data
Date: Thu, 14 Mar 2024 11:56:25 +0100 [thread overview]
Message-ID: <ccvjubtxqqd445yb6g5smjko6p3d3ss337waqeoaray2imogyx@zo5hhnbipokv> (raw)
In-Reply-To: <20240314102035.GI1522089@google.com>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
Hey Lee,
On Thu, Mar 14, 2024 at 10:20:35AM +0000, Lee Jones wrote:
> On Wed, 13 Mar 2024, Uwe Kleine-König wrote:
> > On Wed, Mar 13, 2024 at 01:48:27PM +0100, Uwe Kleine-König wrote:
> > > struct lp8788_bl {
> > > struct lp8788 *lp;
> > > struct backlight_device *bl_dev;
> > > - struct lp8788_backlight_platform_data *pdata;
> > > - enum lp8788_bl_ctrl_mode mode;
> > > struct pwm_device *pwm;
> >
> > Actually this pwm_device member should be dropped, too. I wonder why
> > this even passes a W=1 build without a warning ...
> >
> > @Lee: Feel free to fix this up while applying, or tell me if you prefer
> > an incremental fixup or a complete v2.
>
> Either of the last 2 options would be fine.
I'd prefert a v2 then. Added to my today's todo list.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-03-14 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 12:48 [PATCH] backlight: lp8788: Drop support for platform data Uwe Kleine-König
2024-03-13 21:36 ` Uwe Kleine-König
2024-03-14 10:20 ` Lee Jones
2024-03-14 10:56 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccvjubtxqqd445yb6g5smjko6p3d3ss337waqeoaray2imogyx@zo5hhnbipokv \
--to=u.kleine-koenig@pengutronix.de \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).