From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Raag Jadav <raag.jadav@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels
Date: Fri, 12 Apr 2024 18:57:15 +0200 [thread overview]
Message-ID: <drz5rhytvwjpsywdspdr3q6vqeo2g5icq3th3cx5awbvqcr6bt@quxusf4jafc2> (raw)
In-Reply-To: <ZhlUFZDTQum5-AIR@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
Hello,
On Fri, Apr 12, 2024 at 06:32:37PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 12, 2024 at 01:12:48PM +0200, Uwe Kleine-König wrote:
> > On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:
>
> ...
>
> > > +struct dwc_pwm_drvdata {
> > > + const struct dwc_pwm_info *info;
> > > + void __iomem *io_base;
> >
> > .io_base is only used during init time and so doesn't need to be tracked
> > in driver data.
>
> It's me who asked for this specific change and I think it's still beneficial
> as it allows to simplify the code.
Ok then, feel free to keep it for v2 then.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-04-12 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 6:08 [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels Raag Jadav
2024-04-12 11:12 ` Uwe Kleine-König
2024-04-12 15:32 ` Andy Shevchenko
2024-04-12 16:57 ` Uwe Kleine-König [this message]
2024-04-12 15:38 ` Raag Jadav
2024-04-12 15:45 ` Andy Shevchenko
2024-04-12 16:12 ` Raag Jadav
2024-04-12 15:35 ` Andy Shevchenko
2024-04-12 16:15 ` Raag Jadav
2024-04-12 16:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=drz5rhytvwjpsywdspdr3q6vqeo2g5icq3th3cx5awbvqcr6bt@quxusf4jafc2 \
--to=u.kleine-koenig@pengutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).