From: neil.armstrong@linaro.org
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kevin Hilman" <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-pwm@vger.kernel.org,
"JunYi Zhao" <junyi.zhao@amlogic.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH v3 2/4] dt-bindings: pwm: amlogic: add new compatible for meson8 pwm type
Date: Thu, 30 Nov 2023 10:13:11 +0100 [thread overview]
Message-ID: <f572c729-d007-46b4-b7ac-442f96b23969@linaro.org> (raw)
In-Reply-To: <e127dcef-3149-443a-9a8c-d24ef4054f09@linaro.org>
On 30/11/2023 09:36, Krzysztof Kozlowski wrote:
> On 29/11/2023 17:41, neil.armstrong@linaro.org wrote:
>>>>> .../devicetree/bindings/pwm/pwm-amlogic.yaml | 52 ++++++++++++++++---
>>>>> 1 file changed, 46 insertions(+), 6 deletions(-)
>>>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>>>>> b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>>>>> index 387976ed36d5..eece390114a3 100644
>>>>> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>>>>> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>>>>> @@ -21,23 +21,35 @@ properties:
>>>>> - amlogic,meson-g12a-ee-pwm
>>>>> - amlogic,meson-g12a-ao-pwm-ab
>>>>> - amlogic,meson-g12a-ao-pwm-cd
>>>>> - - amlogic,meson-s4-pwm
>>>>> + deprecated: true
>>>>> - items:
>>>>> - const: amlogic,meson-gx-pwm
>>>>> - const: amlogic,meson-gxbb-pwm
>>>>> + deprecated: true
>>>>> - items:
>>>>> - const: amlogic,meson-gx-ao-pwm
>>>>> - const: amlogic,meson-gxbb-ao-pwm
>>>>> + deprecated: true
>>>>> - items:
>>>>> - const: amlogic,meson8-pwm
>>>>> - const: amlogic,meson8b-pwm
>>>>> + deprecated: true
>>>>
>>>> I think deprecated should be moved in a third patch
>>>
>>> The complain on v2 was that it was not clear the new binding was making
>>> the old one obsolete. It looked to me that the deprecation old bindings
>>> needed to go together with the introduction of the new.
>>>
>>> I don't mind one way or the other
>>>
>>> Is there a rule somewhere about this ?
>>
>> Not sure about that, I don't think it's a problem to have both valid
>> at the same time, setting them deprecated afterwards looks cleaner
>> to avoid mixing too much changes at the same time.
>
> For me current order is correct and intuitive: you add new binding,
> because old binding was wrong, so the old binding should be deprecated.
> Otherwise you have a state with both new and old binding and one could
> question - why did we need new binding? For dtschema it does not matter,
> but it matters how we read the code.
Ack thx for the clarification
>
> Best regards,
> Krzysztof
>
Thanks,
Neil
next prev parent reply other threads:[~2023-11-30 9:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 13:39 [PATCH v3 0/4] pwm: meson: dt-bindings fixup Jerome Brunet
2023-11-29 13:39 ` [PATCH v3 1/4] dt-bindings: pwm: amlogic: fix s4 bindings Jerome Brunet
2023-11-29 13:39 ` [PATCH v3 2/4] dt-bindings: pwm: amlogic: add new compatible for meson8 pwm type Jerome Brunet
2023-11-29 16:20 ` Neil Armstrong
2023-11-29 16:26 ` Jerome Brunet
2023-11-29 16:41 ` neil.armstrong
2023-11-30 8:36 ` Krzysztof Kozlowski
2023-11-30 9:13 ` neil.armstrong [this message]
2023-11-29 13:39 ` [PATCH v3 3/4] pwm: meson: prepare addition of new compatible types Jerome Brunet
2023-11-29 16:25 ` Neil Armstrong
2023-11-29 13:40 ` [PATCH v3 4/4] pwm: meson: add generic compatible for meson8 to sm1 Jerome Brunet
2023-11-29 16:30 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f572c729-d007-46b4-b7ac-442f96b23969@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=junyi.zhao@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).