From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Paul Cercueil <paul@crapouillou.net>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-mips@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] pwm: jz4740: Don't use dev_err_probe() in .request()
Date: Sat, 13 Jan 2024 09:26:52 +0100 [thread overview]
Message-ID: <pwjhf6humll7vgpny5bwstbmgkqqm5rgxcj7xvfi6xcz74o32l@l2iktgudl6ow> (raw)
In-Reply-To: <8e18487f-7190-425d-b2c9-4877c1db8535@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
Hello,
On Sat, Jan 06, 2024 at 06:20:44PM +0100, Krzysztof Kozlowski wrote:
> On 06/01/2024 15:13, Uwe Kleine-König wrote:
> > dev_err_probe() is only supposed to be used in probe functions. While it
> > probably doesn't hurt, both the EPROBE_DEFER handling and calling
> > device_set_deferred_probe_reason() are conceptually wrong in the request
> > callback. So replace the call by dev_err() and a separate return
> > statement.
> >
> > This effectively reverts commit c0bfe9606e03 ("pwm: jz4740: Simplify
> > with dev_err_probe()").
>
> Too much automation :(
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I added that patch to my for-next branch at
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
with the intention to send it for inclusion in 6.8-rc after being in
next for a few days.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-01-13 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-06 14:13 [PATCH] pwm: jz4740: Don't use dev_err_probe() in .request() Uwe Kleine-König
2024-01-06 17:20 ` Krzysztof Kozlowski
2024-01-13 8:26 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pwjhf6humll7vgpny5bwstbmgkqqm5rgxcj7xvfi6xcz74o32l@l2iktgudl6ow \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).