From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Dong Aisheng <aisheng.dong@nxp.com>
Cc: linux-pwm@vger.kernel.org, imx@lists.linux.dev,
dongas86@gmail.com, shawnguo@kernel.org, kernel@pengutronix.de,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] pwm: imx-tpm: fix probe crash due to access registers without clock
Date: Mon, 4 Mar 2024 11:48:37 +0100 [thread overview]
Message-ID: <qpk3pwirjmxf4agstv6bisdefrzv5k24uxiszyobpf7yw3mxt3@ryj7hoyvp4cc> (raw)
In-Reply-To: <20240304102929.893542-1-aisheng.dong@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 2283 bytes --]
Hello Dong,
On Mon, Mar 04, 2024 at 06:29:29PM +0800, Dong Aisheng wrote:
> The following commit abf6569d6482 ("pwm: imx-tpm: Make use of
> devm_pwmchip_alloc() function") introduced an issue that accessing
> registers without clock which results in the following boot crash
> on MX7ULP platform. Fixed it by enabling clock properly.
>
> Unhandled fault: external abort on non-linefetch (0x1008) at 0xf0978004
> [f0978004] *pgd=64009811, *pte=40250653, *ppte=40250453
> Internal error: : 1008 [#1] SMP ARM
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0-rc6-next-20240301 #18
> Hardware name: Freescale i.MX7ULP (Device Tree)
> PC is at pwm_imx_tpm_probe+0x1c/0xd8
> LR is at __devm_ioremap_resource+0xf8/0x1dc
> pc : [<c0629e58>] lr : [<c0562d4c>] psr: 80000053
> sp : f0825e10 ip : 00000000 fp : 00000000
> r10: c148f8c0 r9 : c41fc338 r8 : c164b000
> r7 : 00000000 r6 : c406b400 r5 : c406b410 r4 : f0978000
> r3 : 00000005 r2 : 00000000 r1 : a0000053 r0 : f0978000
> Flags: Nzcv IRQs on FIQs off Mode SVC_32 ISA ARM Segment none
> Control: 10c5387d Table: 6000406a DAC: 00000051
> ...
> Call trace:
> pwm_imx_tpm_probe from platform_probe+0x58/0xb0
> platform_probe from really_probe+0xc4/0x2e0
> really_probe from __driver_probe_device+0x84/0x19c
> __driver_probe_device from driver_probe_device+0x2c/0x104
> driver_probe_device from __driver_attach+0x90/0x170
> __driver_attach from bus_for_each_dev+0x7c/0xd0
> bus_for_each_dev from bus_add_driver+0xc4/0x1cc
> bus_add_driver from driver_register+0x7c/0x114
> driver_register from do_one_initcall+0x58/0x270
> do_one_initcall from kernel_init_freeable+0x170/0x218
> kernel_init_freeable from kernel_init+0x14/0x140
> kernel_init from ret_from_fork+0x14/0x20
>
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Fixes: abf6569d6482 ("pwm: imx-tpm: Make use of devm_pwmchip_alloc() function")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
LGTM, applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-03-04 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 10:29 [PATCH 1/1] pwm: imx-tpm: fix probe crash due to access registers without clock Dong Aisheng
2024-03-04 10:48 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qpk3pwirjmxf4agstv6bisdefrzv5k24uxiszyobpf7yw3mxt3@ryj7hoyvp4cc \
--to=u.kleine-koenig@pengutronix.de \
--cc=aisheng.dong@nxp.com \
--cc=dongas86@gmail.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).