From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: pratikmanvar09@gmail.com, linux-pwm@vger.kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
Pratik Manvar <pratik.manvar@ifm.com>,
linux-kernel@vger.kernel.org, thierry.reding@gmail.com,
Clark Wang <xiaoning.wang@nxp.com>,
linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org, Jun Li <jun.li@nxp.com>
Subject: Re: [PATCH] pwm: imx27: workaround of the pwm output bug
Date: Wed, 3 Jan 2024 13:18:14 +0100 [thread overview]
Message-ID: <sdqgerar4utskfvp2pxbjsjesf2s5zuxtlssur2v3kdvq5m7a6@jaueiad7zvcf> (raw)
In-Reply-To: <20240103103421.GA3758@francesco-nb>
[-- Attachment #1: Type: text/plain, Size: 1673 bytes --]
On Wed, Jan 03, 2024 at 11:34:21AM +0100, Francesco Dolcini wrote:
> On Fri, Dec 29, 2023 at 12:00:07PM +0530, pratikmanvar09@gmail.com wrote:
> > From: Clark Wang <xiaoning.wang@nxp.com>
> >
> > This fixes the pwm output bug when decrease the duty cycle.
> > This is a limited workaround for the PWM IP issue TKT0577206.
> >
> > Root cause:
> > When the SAR FIFO is empty, the new write value will be directly applied
> > to SAR even the current period is not over.
> > If the new SAR value is less than the old one, and the counter is
> > greater than the new SAR value, the current period will not filp the
> > level. This will result in a pulse with a duty cycle of 100%.
> >
> > Workaround:
> > Add an old value SAR write before updating the new duty cycle to SAR.
> > This will keep the new value is always in a not empty fifo, and can be
> > wait to update after a period finished.
> >
> > Limitation:
> > This workaround can only solve this issue when the PWM period is longer
> > than 2us(or <500KHz).
> >
> > Reviewed-by: Jun Li <jun.li@nxp.com>
> > Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> > Link: https://github.com/nxp-imx/linux-imx/commit/16181cc4eee61d87cbaba0e5a479990507816317
> > Tested-by: Pratik Manvar <pratik.manvar@ifm.com>
>
> You need to add your signed-off-by at the end when sending a patch, no
> matter if you are the author or not.
FTR: This also applies to the v2 patch. I discarded both from the pwm
patchwork.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-01-03 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 6:30 [PATCH] pwm: imx27: workaround of the pwm output bug pratikmanvar09
2023-12-30 2:01 ` kernel test robot
2024-01-03 6:34 ` [PATCH v2] " pratikmanvar09
2024-01-03 11:00 ` Stefan Wahren
2024-02-04 6:36 ` pratikmanvar09
2024-02-04 10:02 ` Stefan Wahren
2024-03-05 9:24 ` pratikmanvar09
2024-01-03 10:34 ` [PATCH] " Francesco Dolcini
2024-01-03 11:02 ` [PATCH v3] " pratikmanvar09
2024-01-03 12:20 ` Francesco Dolcini
2024-01-24 11:48 ` Stefan Wahren
2024-01-25 21:28 ` Uwe Kleine-König
2024-03-05 9:27 ` pratikmanvar09
2024-01-03 12:18 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sdqgerar4utskfvp2pxbjsjesf2s5zuxtlssur2v3kdvq5m7a6@jaueiad7zvcf \
--to=u.kleine-koenig@pengutronix.de \
--cc=festevam@gmail.com \
--cc=francesco@dolcini.it \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=pratik.manvar@ifm.com \
--cc=pratikmanvar09@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).