From: Milan Broz <gmazyland@gmail.com>
To: "Weiß, Simone" <Simone.Weiss@elektrobit.com>,
"mpatocka@redhat.com" <mpatocka@redhat.com>
Cc: "song@kernel.org" <song@kernel.org>,
"Tomerius, Kai" <Kai.Tomerius@elektrobit.com>,
"simone.p.weiss@posteo.net" <simone.p.weiss@posteo.net>,
"agk@redhat.com" <agk@redhat.com>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"dm-devel@lists.linux.dev" <dm-devel@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yukuai3@huawei.com" <yukuai3@huawei.com>,
"lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
"snitzer@kernel.org" <snitzer@kernel.org>
Subject: Re: [PATCH] [RFQ] dm-integrity: Add a lazy commit mode for journal
Date: Mon, 26 Feb 2024 09:48:05 +0100 [thread overview]
Message-ID: <48f94af1-3969-4021-84f7-5822bd92b38e@gmail.com> (raw)
In-Reply-To: <a0ff2007f08b7a55e3aa58f1cac2b9314559f598.camel@elektrobit.com>
On 2/26/24 7:47 AM, Weiß, Simone wrote:
...
> I can do it this way for sure as well. Another point still in my mind is the
> superblock: I would like to get rid of the build time switch and carry
> information about lazy commits enabled in the superblock. As there is J, B, D
> and R as mode already, a new mode L or such could be added. I will work on this
> and also take a look at stuff like dmsetup to check if something would be needed
> there. If there are further points for now on anyone's mind, please tell.
Just FYI: I do not think you need to add anything to dmsetup, but integritysetup
(part of the cryptsetup project) needs to understand new metadata and dm-integrity
table options.
And I guess it needs to add a new option to use the new mode.
Perhaps it is best to create an issue for cryptsetup to discuss it, but it will not
be merged until the kernel code is on the way to mainline.
Milan
prev parent reply other threads:[~2024-02-26 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 19:25 [PATCH] [RFQ] dm-integrity: Add a lazy commit mode for journal Simone Weiß
2024-02-20 18:52 ` Mikulas Patocka
2024-02-23 17:53 ` Weiß, Simone
2024-02-23 20:33 ` Mikulas Patocka
2024-02-26 6:47 ` Weiß, Simone
2024-02-26 8:48 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48f94af1-3969-4021-84f7-5822bd92b38e@gmail.com \
--to=gmazyland@gmail.com \
--cc=Kai.Tomerius@elektrobit.com \
--cc=Simone.Weiss@elektrobit.com \
--cc=agk@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mpatocka@redhat.com \
--cc=simone.p.weiss@posteo.net \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).