From: Song Liu <song@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: logang@deltatee.com, dan@danm.net, junxiao.bi@oracle.com,
xni@redhat.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH] md/raid5: fix deadlock that raid5d() wait for itself to clear MD_SB_CHANGE_PENDING
Date: Wed, 10 Apr 2024 14:37:36 -0700 [thread overview]
Message-ID: <CAPhsuW4XSdtSYxVu9rDzDZZfy3AzACJMCej=sC5hUO3QmJJpxg@mail.gmail.com> (raw)
In-Reply-To: <20240322081005.1112401-1-yukuai1@huaweicloud.com>
On Fri, Mar 22, 2024 at 1:17 AM Yu Kuai <yukuai1@huaweicloud.com> wrote:
[...]
>
> Refer to the implementation from raid1 and raid10, fix this problem by
> skipping issue IO if MD_SB_CHANGE_PENDING is still set after
> md_check_recovery(), daemon thread will be woken up when 'reconfig_mutex'
> is released. Meanwhile, the hang problem will be fixed as well.
>
> Fixes: 5e2cf333b7bd ("md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d")
> Reported-and-tested-by: Dan Moulding <dan@danm.net>
> Closes: https://lore.kernel.org/all/20240123005700.9302-1-dan@danm.net/
> Investigated-by: Junxiao Bi <junxiao.bi@oracle.com>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Applied to md-6.10. Thanks!
Song
prev parent reply other threads:[~2024-04-10 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 8:10 [PATCH] md/raid5: fix deadlock that raid5d() wait for itself to clear MD_SB_CHANGE_PENDING Yu Kuai
2024-04-10 21:37 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW4XSdtSYxVu9rDzDZZfy3AzACJMCej=sC5hUO3QmJJpxg@mail.gmail.com' \
--to=song@kernel.org \
--cc=dan@danm.net \
--cc=junxiao.bi@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).