From: Song Liu <songliubraving@meta.com>
To: Mike Snitzer <snitzer@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Song Liu <songliubraving@meta.com>,
linux-raid <linux-raid@vger.kernel.org>,
"dm-devel@lists.linux.dev" <dm-devel@lists.linux.dev>,
Xiao Ni <xni@redhat.com>, Yu Kuai <yukuai3@huawei.com>,
Yu Kuai <yukuai1@huaweicloud.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Junxiao Bi <junxiao.bi@oracle.com>, Dan Moulding <dan@danm.net>,
Song Liu <song@kernel.org>
Subject: Re: [GIT PULL] md-6.8 20240305
Date: Tue, 5 Mar 2024 20:30:49 +0000 [thread overview]
Message-ID: <D50A6003-6A85-4EC0-98EC-A69FAD82273C@fb.com> (raw)
In-Reply-To: <Zedveg1t6VK-vNiO@redhat.com>
Hi Jens and Mike,
> On Mar 5, 2024, at 11:16 AM, Mike Snitzer <snitzer@kernel.org> wrote:
>
> On Tue, Mar 05 2024 at 1:49P -0500,
> Jens Axboe <axboe@kernel.dk> wrote:
>
>> On 3/5/24 11:47 AM, Song Liu wrote:
>>> Hi Jens,
>>>
>>> Please consider pulling the following fixes for md-6.8 on top of your
>>> block-6.8 branch. This set fixes two issues:
>>>
>>> 1. dmraid regression since 6.7 kernels. This issue was initially
>>> reported in [1]. This set of fix has been reviewed and tested by
>>> md and dm folks.
>>>
>>> 2. raid5 hang since 6.7 kernel, reported in [2]. We haven't got a
>>> better fix for this issue yet. This revert is a workaround. It has
>>> been applied to 6.7 stable kernels [3], and proved to be affective.
>>> We will look more into this issue for a better fix.
>>>
>>> We understand this is really last minute for the 6.8 release. But based
>>> on the data we have, these changes are safe and fix issues in the 6.8
>>> kernel.
>>
>> There's just no way we're doing this much at this late in the process,
>> particularly when these are a) not introduced in the 6.8 cycle, and b)
>> we're not even a week away from the merge window. Doing them now for 6.8
>> would just further risk stability there, no matter how well it's tested,
>> and it won't really reduce the time to stable anyway. Hence no, please
>> add these to the 6.9 queue.
>
> I agree.
>
> Song, please revisit each commit's header to make sure they are
> flagged for stable@ if appropriate (e.g. either add a Fixes: tag or
> explicitly Cc: stable@).
Thanks for the suggestions. I will resend them via md-6.9 branch.
Song
prev parent reply other threads:[~2024-03-05 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 18:47 [GIT PULL] md-6.8 20240305 Song Liu
2024-03-05 18:49 ` Jens Axboe
2024-03-05 19:16 ` Mike Snitzer
2024-03-05 20:30 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D50A6003-6A85-4EC0-98EC-A69FAD82273C@fb.com \
--to=songliubraving@meta.com \
--cc=axboe@kernel.dk \
--cc=bmarzins@redhat.com \
--cc=dan@danm.net \
--cc=dm-devel@lists.linux.dev \
--cc=junxiao.bi@oracle.com \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).