* [PATCH for-rc] RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server
@ 2021-03-19 19:47 Potnuri Bharat Teja
2021-03-19 22:34 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Potnuri Bharat Teja @ 2021-03-19 19:47 UTC (permalink / raw
To: jgg, dledford; +Cc: linux-rdma, bharat
While destroying ipv6 listening servers, set ipv6 field to '1' and pass it
down to the HW.
Fixes: 830662f6f032 ("RDMA/cxgb4: Add support for active and passive open connection with IPv6 address")
Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
---
drivers/infiniband/hw/cxgb4/cm.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 8769e7aa097f..76faba892f00 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -3599,8 +3599,9 @@ int c4iw_create_listen(struct iw_cm_id *cm_id, int backlog)
int c4iw_destroy_listen(struct iw_cm_id *cm_id)
{
- int err;
struct c4iw_listen_ep *ep = to_listen_ep(cm_id);
+ bool ipv6 = false;
+ int err;
pr_debug("ep %p\n", ep);
@@ -3610,13 +3611,14 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id)
ep->com.local_addr.ss_family == AF_INET) {
err = cxgb4_remove_server_filter(
ep->com.dev->rdev.lldi.ports[0], ep->stid,
- ep->com.dev->rdev.lldi.rxq_ids[0], 0);
+ ep->com.dev->rdev.lldi.rxq_ids[0], ipv6);
} else {
struct sockaddr_in6 *sin6;
+ ipv6 = true;
c4iw_init_wr_wait(ep->com.wr_waitp);
err = cxgb4_remove_server(
ep->com.dev->rdev.lldi.ports[0], ep->stid,
- ep->com.dev->rdev.lldi.rxq_ids[0], 0);
+ ep->com.dev->rdev.lldi.rxq_ids[0], ipv6);
if (err)
goto done;
err = c4iw_wait_for_reply(&ep->com.dev->rdev, ep->com.wr_waitp,
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-rc] RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server
2021-03-19 19:47 [PATCH for-rc] RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server Potnuri Bharat Teja
@ 2021-03-19 22:34 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2021-03-19 22:34 UTC (permalink / raw
To: Potnuri Bharat Teja; +Cc: dledford, linux-rdma
On Sat, Mar 20, 2021 at 01:17:21AM +0530, Potnuri Bharat Teja wrote:
> While destroying ipv6 listening servers, set ipv6 field to '1' and pass it
> down to the HW.
You need to explain more if you want this in -rc, what is the user
visible impact?
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-19 22:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-19 19:47 [PATCH for-rc] RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server Potnuri Bharat Teja
2021-03-19 22:34 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).