From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Leon Romanovsky <leon@kernel.org>,
Konstantin Taranov <kotaranov@microsoft.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Long Li <longli@microsoft.com>,
Ajay Sharma <sharmaajay@microsoft.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error
Date: Tue, 23 Apr 2024 23:42:58 +0300 [thread overview]
Message-ID: <20240423204258.3669706-1-andriy.shevchenko@linux.intel.com> (raw)
The compilation with CONFIG_WERROR=y is broken:
.../hw/mana/device.c:88:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
if (!upper_ndev) {
^~~~~~~~~~~
Fix this by assigning the ret to -ENODEV in respective condition.
Fixes: 8b184e4f1c32 ("RDMA/mana_ib: Enable RoCE on port 1")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/infiniband/hw/mana/device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c
index fca4d0d85c64..4c45f8681e7f 100644
--- a/drivers/infiniband/hw/mana/device.c
+++ b/drivers/infiniband/hw/mana/device.c
@@ -88,6 +88,7 @@ static int mana_ib_probe(struct auxiliary_device *adev,
if (!upper_ndev) {
rcu_read_unlock();
ibdev_err(&dev->ib_dev, "Failed to get master netdev");
+ ret = -ENODEV;
goto free_ib_device;
}
ether_addr_copy(mac_addr, upper_ndev->dev_addr);
--
2.43.0.rc1.1336.g36b5255a03ac
next reply other threads:[~2024-04-23 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 20:42 Andy Shevchenko [this message]
2024-04-23 23:58 ` [PATCH v1 1/1] RDMA/mana_ib: Fix compilation error Long Li
2024-04-26 16:37 ` Jason Gunthorpe
2024-04-26 16:50 ` Andy Shevchenko
2024-04-26 16:56 ` Andy Shevchenko
2024-04-26 16:58 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423204258.3669706-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=kotaranov@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=sharmaajay@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).