Linux-RDMA Archive mirror
 help / color / mirror / Atom feed
From: "santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org" <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Sagi Grimberg
	<sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Nicholas A. Bellinger"
	<nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
Subject: Re: [PATCH v1 00/24] New fast registration API
Date: Mon, 21 Sep 2015 16:28:10 -0700	[thread overview]
Message-ID: <5600928A.7070202@oracle.com> (raw)
In-Reply-To: <55FE7E24.20300-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>

Hi Sagi,

On 9/20/15 2:36 AM, Sagi Grimberg wrote:
> Hi Santosh,
>
>> Nice to see this consolidaton happening. I too don't have access to
>> iWARP hardware for RDS test but will use this series and convert our WIP
>> IB fastreg code and see how it goes.
>
> I'm very pleased to hear about this WIP. Please feel free to share
> anything you have (code and questions/dilemmas) with the list. Also, if
> you have more suggestions on how we can do better from your PoV we'd
> love to hear about it.
>
So as promised, I tried to test your series.  Your github branch [1]
'reg_api.3' though mostly has 4.3-rc1 contents, it isn't
based of 4.3-rc1 so I just cherry picked the patches and created
'rdma/sagi/reg_api.3_cherrypick' [2]. I had conflict with iser
patch so I just dropped that one.

As mentioned earlier, I have a WIP RDS fastreg branch [3]
which is functional (at least I can RDMA messages across
nodes ;-)). So merging [2] and [3], I created [4] and applied
a delta change based on your other patches. I saw ib_post_send
failure with my HCA driver returning '-EINVAL'. I didn't
debug it further but at least opcode and num_sge were set
correctly so I shouldn't have seen it. So I did memset()
on reg_wr which seems to have helped to fix the ib_post_send()
failure.

But I got into remote access errors which tells me that I
have messed up setup(rkey, sge setup or access flags)
or missing some other patch(s) in my test tree[4]. Delta
patch is top commit on [4].

Please let me know if you spot something which I missed.

Regards,
Santosh

[1] https://github.com/sagigrimberg/linux/tree/reg_api.3
[2] 
https://git.kernel.org/cgit/linux/kernel/git/ssantosh/linux.git/log/?h=rdma/sagi/reg_api.3_cherrypick
[3] 
https://git.kernel.org/cgit/linux/kernel/git/ssantosh/linux.git/log/?h=net/rds/4.3-fr-wip
[4]https://git.kernel.org/cgit/linux/kernel/git/ssantosh/linux.git/commit/?h=test/reg_api.3/rds
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-09-21 23:28 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  9:42 [PATCH v1 00/24] New fast registration API Sagi Grimberg
     [not found] ` <1442482947-27785-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-17  9:42   ` [PATCH v1 01/24] IB/core: Introduce new " Sagi Grimberg
     [not found]     ` <1442482947-27785-2-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-22 21:21       ` Bart Van Assche
     [not found]         ` <5601C65F.8060403-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-09-24  7:37           ` Sagi Grimberg
     [not found]             ` <5603A841.70509-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-09-28 20:57               ` Bart Van Assche
     [not found]                 ` <5609A9D0.8030607-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-09-29  5:59                   ` Christoph Hellwig
     [not found]                     ` <20150929055907.GA29758-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-09-29  6:47                       ` Sagi Grimberg
     [not found]                         ` <560A341F.7030108-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-29  6:49                           ` Sagi Grimberg
2015-09-29  6:42                   ` Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 02/24] IB/mlx5: Remove dead fmr code Sagi Grimberg
     [not found]     ` <1442482947-27785-3-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-22 21:24       ` Bart Van Assche
2015-09-17  9:42   ` [PATCH v1 03/24] IB/mlx5: Support the new memory registration API Sagi Grimberg
     [not found]     ` <1442482947-27785-4-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-22 21:27       ` Bart Van Assche
     [not found]         ` <5601C7A4.5030302-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-09-24  7:39           ` Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 04/24] IB/mlx4: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 05/24] RDMA/ocrdma: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 06/24] RDMA/cxgb3: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 07/24] iw_cxgb4: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 08/24] IB/qib: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 09/24] RDMA/nes: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 10/24] IB/iser: Port to new fast " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 11/24] iser-target: Port to new memory " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 12/24] xprtrdma: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 13/24] svcrdma: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 14/24] RDS/IW: Convert " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 15/24] IB/srp: " Sagi Grimberg
     [not found]     ` <1442482947-27785-16-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-22 21:58       ` Bart Van Assche
     [not found]         ` <5601CF20.3040102-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-09-24  9:06           ` Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 16/24] IB/mlx5: Remove old FRWR API support Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 17/24] IB/mlx4: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 18/24] RDMA/ocrdma: Remove old FRWR API Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 19/24] RDMA/cxgb3: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 20/24] iw_cxgb4: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 21/24] IB/qib: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 22/24] RDMA/nes: " Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 23/24] IB/hfi1: Remove Old fast registraion API support Sagi Grimberg
2015-09-17  9:42   ` [PATCH v1 24/24] IB/core: Remove old fast registration API Sagi Grimberg
2015-09-19 22:45   ` [PATCH v1 00/24] New " Christoph Hellwig
     [not found]     ` <20150919224518.GA23027-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-09-24  6:53       ` Sagi Grimberg
     [not found]         ` <56039DE9.1010300-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-09-24 13:39           ` Christoph Hellwig
2015-09-19 23:20   ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
     [not found]     ` <55FDEDD5.1090105-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-09-20  9:36       ` Sagi Grimberg
     [not found]         ` <55FE7E24.20300-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-09-21 23:28           ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA [this message]
     [not found]             ` <5600928A.7070202-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-09-22  7:19               ` Sagi Grimberg
     [not found]                 ` <560100EA.8080302-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-22  7:56                   ` Sagi Grimberg
     [not found]                     ` <560109B7.8070005-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-09-22 18:23                       ` santosh shilimkar
2015-09-22 21:22   ` Bart Van Assche
     [not found]     ` <5601C698.4000509-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-09-24  7:40       ` Sagi Grimberg
2015-09-29 19:03   ` Bart Van Assche
     [not found]     ` <560AE099.2080004-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-09-29 20:58       ` Sagi Grimberg
     [not found]         ` <560AFB71.3010003-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-09-30  6:47           ` Sagi Grimberg
2015-09-30 18:59           ` Bart Van Assche
     [not found]             ` <560C30F4.50900-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-09-30 20:15               ` Bart Van Assche
     [not found]                 ` <560C42CE.6090000-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-10-01  7:16                   ` Sagi Grimberg
     [not found]                     ` <560CDDBC.8000400-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-01 17:53                       ` Bart Van Assche
     [not found]                         ` <560D730C.9000302-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-10-01 20:58                           ` Bart Van Assche
     [not found]                             ` <35618B90-4D6E-4036-A69B-4405F020D440@dev.mellanox.co.il>
     [not found]                               ` <35618B90-4D6E-4036-A69B-4405F020D440-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-02 15:37                                 ` Bart Van Assche
     [not found]                                   ` <560EA4A1.3080709-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-10-06  8:37                                     ` Sagi Grimberg
     [not found]                                       ` <56138854.4040209-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-06 18:49                                         ` Bart Van Assche
     [not found]                                           ` <561417B9.2080505-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-10-07  6:42                                             ` Sagi Grimberg
     [not found]                                               ` <5614BECF.9030907-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-07 15:46                                                 ` Bart Van Assche
     [not found]                                                   ` <56153E41.10607-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-10-07 15:48                                                     ` Sagi Grimberg
2015-10-07  9:20                                         ` Christoph Hellwig
     [not found]                                           ` <20151007092024.GA18020-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-10-07  9:25                                             ` Sagi Grimberg
     [not found]                                               ` <5614E505.7090808-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-10-07  9:36                                                 ` Christoph Hellwig
     [not found]                                                   ` <20151007093645.GA6940-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-10-07 10:00                                                     ` Sagi Grimberg
2015-10-07 16:30                                             ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5600928A.7070202@oracle.com \
    --to=santosh.shilimkar-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \
    --cc=sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).