* [PATCH] dt-bindings: remoteproc: qcom,sm8550-pas: Add SM8750 ADSP
@ 2024-11-01 17:03 Krzysztof Kozlowski
2024-11-01 17:56 ` Melody Olvera
2024-11-04 15:47 ` Rob Herring (Arm)
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-11-01 17:03 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Melody Olvera,
Satya Durga Srinivasu Prabhala, Srinivas Kandagatla
Document compatible for Qualcomm SM8750 SoC ADSP PAS which looks fully
compatible with SM8550 variant. The only difference from bindings point
of view is one more interrupt ("shutdown-ack"). Marking devices as
compatible, using SM8550 ADSP PAS fallback, requires changing some of
the conditionals in "if:then:" to "contains".
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Melody Olvera <quic_molvera@quicinc.com>
Cc: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
.../bindings/remoteproc/qcom,sm8550-pas.yaml | 48 +++++++++++++------
1 file changed, 34 insertions(+), 14 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index d7fad7b3c2c6..a24cbb61bda7 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -15,16 +15,20 @@ description:
properties:
compatible:
- enum:
- - qcom,sdx75-mpss-pas
- - qcom,sm8550-adsp-pas
- - qcom,sm8550-cdsp-pas
- - qcom,sm8550-mpss-pas
- - qcom,sm8650-adsp-pas
- - qcom,sm8650-cdsp-pas
- - qcom,sm8650-mpss-pas
- - qcom,x1e80100-adsp-pas
- - qcom,x1e80100-cdsp-pas
+ oneOf:
+ - enum:
+ - qcom,sdx75-mpss-pas
+ - qcom,sm8550-adsp-pas
+ - qcom,sm8550-cdsp-pas
+ - qcom,sm8550-mpss-pas
+ - qcom,sm8650-adsp-pas
+ - qcom,sm8650-cdsp-pas
+ - qcom,sm8650-mpss-pas
+ - qcom,x1e80100-adsp-pas
+ - qcom,x1e80100-cdsp-pas
+ - items:
+ - const: qcom,sm8750-adsp-pas
+ - const: qcom,sm8550-adsp-pas
reg:
maxItems: 1
@@ -82,6 +86,20 @@ allOf:
maxItems: 5
memory-region:
maxItems: 2
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sm8750-adsp-pas
+ then:
+ properties:
+ interrupts:
+ maxItems: 6
+ interrupt-names:
+ maxItems: 6
+ memory-region:
+ maxItems: 2
- if:
properties:
compatible:
@@ -129,10 +147,12 @@ allOf:
- if:
properties:
compatible:
- enum:
- - qcom,sm8550-adsp-pas
- - qcom,sm8650-adsp-pas
- - qcom,x1e80100-adsp-pas
+ contains:
+ enum:
+ - qcom,sm8550-adsp-pas
+ - qcom,sm8650-adsp-pas
+ - qcom,sm8750-adsp-pas
+ - qcom,x1e80100-adsp-pas
then:
properties:
power-domains:
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: remoteproc: qcom,sm8550-pas: Add SM8750 ADSP
2024-11-01 17:03 [PATCH] dt-bindings: remoteproc: qcom,sm8550-pas: Add SM8750 ADSP Krzysztof Kozlowski
@ 2024-11-01 17:56 ` Melody Olvera
2024-11-04 15:47 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Melody Olvera @ 2024-11-01 17:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam, linux-arm-msm, linux-remoteproc,
devicetree, linux-kernel
Cc: Satya Durga Srinivasu Prabhala, Srinivas Kandagatla
On 11/1/2024 10:03 AM, Krzysztof Kozlowski wrote:
> Document compatible for Qualcomm SM8750 SoC ADSP PAS which looks fully
> compatible with SM8550 variant. The only difference from bindings point
> of view is one more interrupt ("shutdown-ack"). Marking devices as
> compatible, using SM8550 ADSP PAS fallback, requires changing some of
> the conditionals in "if:then:" to "contains".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Melody Olvera <quic_molvera@quicinc.com>
> Cc: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 48 +++++++++++++------
> 1 file changed, 34 insertions(+), 14 deletions(-)
>
Reviewed-by: Melody Olvera <quic_molvera@quicinc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: remoteproc: qcom,sm8550-pas: Add SM8750 ADSP
2024-11-01 17:03 [PATCH] dt-bindings: remoteproc: qcom,sm8550-pas: Add SM8750 ADSP Krzysztof Kozlowski
2024-11-01 17:56 ` Melody Olvera
@ 2024-11-04 15:47 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-11-04 15:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Melody Olvera, linux-kernel, Srinivas Kandagatla, Conor Dooley,
Krzysztof Kozlowski, Manivannan Sadhasivam, devicetree,
Mathieu Poirier, Satya Durga Srinivasu Prabhala, Bjorn Andersson,
linux-arm-msm, linux-remoteproc
On Fri, 01 Nov 2024 18:03:09 +0100, Krzysztof Kozlowski wrote:
> Document compatible for Qualcomm SM8750 SoC ADSP PAS which looks fully
> compatible with SM8550 variant. The only difference from bindings point
> of view is one more interrupt ("shutdown-ack"). Marking devices as
> compatible, using SM8550 ADSP PAS fallback, requires changing some of
> the conditionals in "if:then:" to "contains".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Melody Olvera <quic_molvera@quicinc.com>
> Cc: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 48 +++++++++++++------
> 1 file changed, 34 insertions(+), 14 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-04 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-01 17:03 [PATCH] dt-bindings: remoteproc: qcom,sm8550-pas: Add SM8750 ADSP Krzysztof Kozlowski
2024-11-01 17:56 ` Melody Olvera
2024-11-04 15:47 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).