From: Zijun Hu <zijun_hu@icloud.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Martin Tuma" <martin.tuma@digiteqautomotive.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Andreas Noever" <andreas.noever@gmail.com>,
"Michael Jamet" <michael.jamet@intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Yehezkel Bernat" <YehezkelShB@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Vishal Verma" <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Lee Duncan" <lduncan@suse.com>,
"Chris Leech" <cleech@redhat.com>,
"Mike Christie" <michael.christie@oracle.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Nilesh Javali" <njavali@marvell.com>,
"Manish Rangankar" <mrangankar@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Jonathan Cameron" <jonathan.cameron@huawei.com>,
"Alison Schofield" <alison.schofield@intel.com>,
"Andreas Larsson" <andreas@gaisler.com>,
"Stuart Yoder" <stuyoder@gmail.com>,
"Laurentiu Tudor" <laurentiu.tudor@nxp.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"Cristian Marussi" <cristian.marussi@arm.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>
Cc: Zijun Hu <zijun_hu@icloud.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org, linux-media@vger.kernel.org,
linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org,
netdev@vger.kernel.org, linux-pwm@vger.kernel.org,
nvdimm@lists.linux.dev, linux1394-devel@lists.sourceforge.net,
linux-serial@vger.kernel.org, linux-sound@vger.kernel.org,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
linux-cxl@vger.kernel.org, sparclinux@vger.kernel.org,
linux-block@vger.kernel.org, arm-scmi@vger.kernel.org,
linux-efi@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Zijun Hu <quic_zijuhu@quicinc.com>
Subject: [PATCH v2 00/32] driver core: Constify API device_find_child() and adapt for various existing usages
Date: Tue, 03 Dec 2024 08:33:22 +0800 [thread overview]
Message-ID: <20241203-const_dfc_done-v2-0-7436a98c497f@quicinc.com> (raw)
This patch series is to constify the following API:
struct device *device_find_child(struct device *dev, void *data,
int (*match)(struct device *dev, void *data));
To :
struct device *device_find_child(struct device *dev, const void *data,
device_match_t match);
typedef int (*device_match_t)(struct device *dev, const void *data);
Why to constify the API?
- Protect caller's match data @*data which is for comparison and lookup
and the API does not actually need to modify @*data.
- Make the API's parameters (@match)() and @data have the same type as
all of other device finding APIs (bus|class|driver)_find_device().
- All kinds of existing device matching functions can be directly taken
as the API's argument, they were exported by driver core.
How to constify the API?
- Now, no (@match)() argument of the API usages is modifying its match
data @*data after previous cleanup, so it is easy and safe to make its
parameter @data take const void * as type.
- Simplify involved codes further if it is possbile with benefits
brought by constifying the API.
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
Changes in v2:
- Series v1 have no code review comments and are posted a long time ago, so may ignore differences.
- Link to v1: https://lore.kernel.org/r/20240811-const_dfc_done-v1-0-9d85e3f943cb@quicinc.com
- Motivation link: https://lore.kernel.org/lkml/917359cc-a421-41dd-93f4-d28937fe2325@icloud.com
---
Zijun Hu (32):
driver core: Constify API device_find_child()
driver core: Introduce device_match_type() to match device with a device type
drm/mediatek: Adapt for constified device_find_child()
hwmon: Adapt for constified device_find_child()
media: pci: mgb4: Adapt for constified device_find_child()
thunderbolt: Adapt for constified device_find_child()
gpio: sim: Remove gpio_sim_dev_match_fwnode()
net: dsa: Adapt for constified device_find_child()
pwm: Adapt for constified device_find_child()
nvdimm: Adapt for constified device_find_child()
libnvdimm: Simplify nd_namespace_store() implementation
firewire: core: Adapt for constified device_find_child()
serial: core: Adapt for constified device_find_child()
usb: typec: class: Remove both cable_match() and partner_match()
usb: typec: class: Adapt for constified device_find_child()
slimbus: core: Simplify of_find_slim_device() implementation
slimbus: core: Constify slim_eaddr_equal()
slimbus: core: Adapt for constified device_find_child()
scsi: iscsi: Constify API iscsi_find_flashnode_sess()
scsi: qla4xxx: Adapt for constified iscsi_find_flashnode_sess()
scsi: iscsi: Adapt for constified device_find_child()
cxl/region: Adapt for constified device_find_child()
cxl/pmem: Remove match_nvdimm_bridge()
cxl/core/pci: Adapt for constified device_find_child()
cxl/test: Adapt for constified device_find_child()
sparc: vio: Adapt for constified device_find_child()
bus: fsl-mc: Adapt for constified device_find_child()
block: sunvdc: Adapt for constified device_find_child()
firmware: arm_scmi: Adapt for constified device_find_child()
efi: dev-path-parser: Adapt for constified device_find_child()
rpmsg: core: Adapt for constified device_find_child()
driver core: Simplify API device_find_child_by_name() implementation
arch/sparc/kernel/vio.c | 6 +++---
drivers/base/core.c | 30 ++++++++++--------------------
drivers/block/sunvdc.c | 6 +++---
drivers/bus/fsl-mc/dprc-driver.c | 6 +++---
drivers/cxl/core/pci.c | 4 ++--
drivers/cxl/core/pmem.c | 9 +++------
drivers/cxl/core/region.c | 21 ++++++++++++---------
drivers/firewire/core-device.c | 4 ++--
drivers/firmware/arm_scmi/bus.c | 4 ++--
drivers/firmware/efi/dev-path-parser.c | 4 ++--
drivers/gpio/gpio-sim.c | 7 +------
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +-
drivers/hwmon/hwmon.c | 2 +-
drivers/media/pci/mgb4/mgb4_core.c | 4 ++--
drivers/nvdimm/bus.c | 2 +-
drivers/nvdimm/claim.c | 9 +--------
drivers/pwm/core.c | 2 +-
drivers/rpmsg/rpmsg_core.c | 4 ++--
drivers/scsi/qla4xxx/ql4_os.c | 3 ++-
drivers/scsi/scsi_transport_iscsi.c | 10 +++++-----
drivers/slimbus/core.c | 17 +++++------------
drivers/thunderbolt/retimer.c | 2 +-
drivers/thunderbolt/xdomain.c | 2 +-
drivers/tty/serial/serial_core.c | 4 ++--
drivers/usb/typec/class.c | 31 ++++++++++++++-----------------
include/linux/device.h | 4 ++--
include/linux/device/bus.h | 1 +
include/scsi/scsi_transport_iscsi.h | 4 ++--
net/dsa/dsa.c | 2 +-
tools/testing/cxl/test/cxl.c | 2 +-
30 files changed, 89 insertions(+), 119 deletions(-)
---
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
change-id: 20241201-const_dfc_done-aaec71e3bbea
Best regards,
--
Zijun Hu <quic_zijuhu@quicinc.com>
next reply other threads:[~2024-12-03 0:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 0:33 Zijun Hu [this message]
2024-12-03 0:33 ` [PATCH v2 01/32] driver core: Constify API device_find_child() Zijun Hu
2024-12-03 0:33 ` [PATCH v2 02/32] driver core: Introduce device_match_type() to match device with a device type Zijun Hu
2024-12-03 0:33 ` [PATCH v2 03/32] drm/mediatek: Adapt for constified device_find_child() Zijun Hu
2024-12-03 0:33 ` [PATCH v2 04/32] hwmon: " Zijun Hu
2024-12-03 0:33 ` [PATCH v2 05/32] media: pci: mgb4: " Zijun Hu
2024-12-03 0:33 ` [PATCH v2 06/32] thunderbolt: " Zijun Hu
2024-12-03 0:33 ` [PATCH v2 07/32] gpio: sim: Remove gpio_sim_dev_match_fwnode() Zijun Hu
2024-12-03 0:33 ` [PATCH v2 08/32] net: dsa: Adapt for constified device_find_child() Zijun Hu
2024-12-03 0:33 ` [PATCH v2 09/32] pwm: " Zijun Hu
2024-12-03 0:33 ` [PATCH v2 10/32] nvdimm: " Zijun Hu
2024-12-03 0:33 ` [PATCH v2 11/32] libnvdimm: Simplify nd_namespace_store() implementation Zijun Hu
2024-12-03 2:29 ` [PATCH v2 00/32] driver core: Constify API device_find_child() and adapt for various existing usages quic_zijuhu
2024-12-03 12:00 ` Uwe Kleine-König
2024-12-03 12:23 ` Zijun Hu
2024-12-03 12:41 ` Greg Kroah-Hartman
2024-12-03 13:02 ` Zijun Hu
2024-12-03 13:58 ` James Bottomley
2024-12-03 14:07 ` Thomas Weißschuh
2024-12-03 14:56 ` Zijun Hu
2024-12-03 15:34 ` James Bottomley
2024-12-04 12:26 ` Zijun Hu
2024-12-04 16:42 ` James Bottomley
2024-12-05 0:07 ` Zijun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203-const_dfc_done-v2-0-7436a98c497f@quicinc.com \
--to=zijun_hu@icloud.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=YehezkelShB@gmail.com \
--cc=airlied@gmail.com \
--cc=alison.schofield@intel.com \
--cc=andersson@kernel.org \
--cc=andreas.noever@gmail.com \
--cc=andreas@gaisler.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ardb@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=axboe@kernel.dk \
--cc=brgl@bgdev.pl \
--cc=chunkuang.hu@kernel.org \
--cc=cleech@redhat.com \
--cc=cristian.marussi@arm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=horms@kernel.org \
--cc=ira.weiny@intel.com \
--cc=jdelvare@suse.com \
--cc=jirislaby@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=laurentiu.tudor@nxp.com \
--cc=lduncan@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=linux@roeck-us.net \
--cc=martin.petersen@oracle.com \
--cc=martin.tuma@digiteqautomotive.com \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=michael.christie@oracle.com \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mrangankar@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=nvdimm@lists.linux.dev \
--cc=o-takashi@sakamocchi.jp \
--cc=olteanv@gmail.com \
--cc=open-iscsi@googlegroups.com \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=quic_zijuhu@quicinc.com \
--cc=rafael@kernel.org \
--cc=simona@ffwll.ch \
--cc=sparclinux@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=stuyoder@gmail.com \
--cc=sudeep.holla@arm.com \
--cc=ukleinek@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).