From: Jingyi Wang <quic_jingyw@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
<quic_tengfan@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Xin Liu <quic_liuxin@quicinc.com>
Subject: Re: [PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc
Date: Wed, 25 Sep 2024 16:35:10 +0800 [thread overview]
Message-ID: <2144d060-7454-46a3-96ed-6173e1ba2523@quicinc.com> (raw)
In-Reply-To: <bxkkqezsvvgf7xi6nhxjdpxhr76lrcjp65gtk56x45nhkygdmh@z3lzuz6honcg>
On 9/25/2024 4:01 PM, Dmitry Baryshkov wrote:
> On Wed, Sep 25, 2024 at 03:21:37PM GMT, Jingyi Wang wrote:
>> Document the components used to boot the ADSP, CDSP and GPDSP on the
>> Qualcomm QCS8300 SoC. Use fallback to indicate the compatibility of the
>> remoteproc on the QCS8300 with that on the SA8775P.
Hi Dmitry,
>
> Are there any SoC-specific quirks that demand a separate compat string?
>
> In other similar cases (sm8250 vs qrb5165, sc7280 vs qcm6490 vs qcs6490
> we are adding new compatibles only if it is expected that the hardware
> (or firmware) is actually different.
>
This case is different from the cases above as qcs8300 and sa8775p are
different SoCs.(sm8250 and qrb5165 are different variants for the same
SoC). QCS8300 has one cdsp&gpdsp while SA8775P has 2, but they share the
same driver data, we used to discuss with Krzysztof how to deal case
like this and got the following suggestion to use fallback in yaml:
https://lore.kernel.org/all/6652a08e-7143-4214-a864-9f27c10d7571@kernel.org/
>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>> ---
>> Changes in v3:
>> - add "contains" and remove redundant compatible.
>> - Link to v2: https://lore.kernel.org/r/20240911-qcs8300_remoteproc_binding-v2-1-01921b110532@quicinc.com
>>
>> Changes in v2:
>> - decoupled from the original series.
>> - Use fallback to indicate compatibility with SA8775P.
>> - Link to v1: https://lore.kernel.org/r/20240904-qcs8300_initial_dtsi-v1-0-d0ea9afdc007@quicinc.com
>> ---
>> .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 44 +++++++++++++++-------
>> 1 file changed, 30 insertions(+), 14 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>> index 7fe401a06805..a66007951d58 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>> @@ -15,12 +15,25 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - qcom,sa8775p-adsp-pas
>> - - qcom,sa8775p-cdsp0-pas
>> - - qcom,sa8775p-cdsp1-pas
>> - - qcom,sa8775p-gpdsp0-pas
>> - - qcom,sa8775p-gpdsp1-pas
>> + oneOf:
>> + - items:
>> + - enum:
>> + - qcom,qcs8300-adsp-pas
>> + - const: qcom,sa8775p-adsp-pas
>> + - items:
>> + - enum:
>> + - qcom,qcs8300-cdsp-pas
>> + - const: qcom,sa8775p-cdsp0-pas
>> + - items:
>> + - enum:
>> + - qcom,qcs8300-gpdsp-pas
>> + - const: qcom,sa8775p-gpdsp0-pas
>> + - enum:
>> + - qcom,sa8775p-adsp-pas
>> + - qcom,sa8775p-cdsp0-pas
>> + - qcom,sa8775p-cdsp1-pas
>> + - qcom,sa8775p-gpdsp0-pas
>> + - qcom,sa8775p-gpdsp1-pas
>>
>> reg:
>> maxItems: 1
>> @@ -63,8 +76,9 @@ allOf:
>> - if:
>> properties:
>> compatible:
>> - enum:
>> - - qcom,sa8775p-adsp-pas
>> + contains:
>> + enum:
>> + - qcom,sa8775p-adsp-pas
>> then:
>> properties:
>> power-domains:
>> @@ -79,9 +93,10 @@ allOf:
>> - if:
>> properties:
>> compatible:
>> - enum:
>> - - qcom,sa8775p-cdsp0-pas
>> - - qcom,sa8775p-cdsp1-pas
>> + contains:
>> + enum:
>> + - qcom,sa8775p-cdsp0-pas
>> + - qcom,sa8775p-cdsp1-pas
>> then:
>> properties:
>> power-domains:
>> @@ -98,9 +113,10 @@ allOf:
>> - if:
>> properties:
>> compatible:
>> - enum:
>> - - qcom,sa8775p-gpdsp0-pas
>> - - qcom,sa8775p-gpdsp1-pas
>> + contains:
>> + enum:
>> + - qcom,sa8775p-gpdsp0-pas
>> + - qcom,sa8775p-gpdsp1-pas
>> then:
>> properties:
>> power-domains:
>>
>> ---
>> base-commit: 4d0326b60bb753627437fff0f76bf1525bcda422
>> change-id: 20240925-qcs8300_remoteproc_binding-a2837bab2150
>>
>> Best regards,
>> --
>> Jingyi Wang <quic_jingyw@quicinc.com>
>>
>
Thanks,
Jingyi
next prev parent reply other threads:[~2024-09-25 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 7:21 [PATCH v3] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc Jingyi Wang
2024-09-25 8:01 ` Dmitry Baryshkov
2024-09-25 8:35 ` Jingyi Wang [this message]
2024-09-25 9:06 ` Dmitry Baryshkov
2024-09-26 6:40 ` Krzysztof Kozlowski
2024-11-14 9:23 ` Jingyi Wang
2025-01-06 18:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2144d060-7454-46a3-96ed-6173e1ba2523@quicinc.com \
--to=quic_jingyw@quicinc.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=quic_liuxin@quicinc.com \
--cc=quic_tengfan@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).