From: Vignesh Viswanathan <quic_viswanat@quicinc.com>
To: Chukun Pan <amadeus@jmu.edu.cn>, Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<linux-remoteproc@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] hwspinlock: qcom: fix tcsr data for ipq6018
Date: Wed, 13 Dec 2023 11:02:09 +0530 [thread overview]
Message-ID: <51133a78-43ca-46fb-8f5e-b3bfdaef9a79@quicinc.com> (raw)
In-Reply-To: <20231212142509.655094-1-amadeus@jmu.edu.cn>
On 12/12/2023 7:55 PM, Chukun Pan wrote:
> The tcsr_mutex hwlock register of the ipq6018 SoC is 0x20000[1], which
> should not use the max_register configuration of older SoCs. This will
> cause smem to be unable to probe, further causing devices that use
> smem-part to parse partitions to fail to boot.
>
> [ 2.118227] qcom-smem: probe of 4aa00000.memory failed with error -110
> [ 22.273120] platform 79b0000.nand-controller: deferred probe pending
>
> Remove 'qcom,ipq6018-tcsr-mutex' setting from of_match to fix this.
Hi Chukun,
This patch was already posted [2] and Bjorn applied the same [3].
Hi Bjorn,
This patch is missing in linux-next. Could you please help check ?
Thanks,
Vignesh
[2] https://lore.kernel.org/all/20230905095535.1263113-3-quic_viswanat@quicinc.com/
[3] https://lore.kernel.org/all/169522934567.2501390.1112201061322984444.b4-ty@kernel.org/
>
> [1] commit 72fc3d58b87b ("arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size")
> Fixes: 5d4753f741d8 ("hwspinlock: qcom: add support for MMIO on older SoCs")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
> drivers/hwspinlock/qcom_hwspinlock.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c
> index a0fd67fd2934..814dfe8697bf 100644
> --- a/drivers/hwspinlock/qcom_hwspinlock.c
> +++ b/drivers/hwspinlock/qcom_hwspinlock.c
> @@ -115,7 +115,6 @@ static const struct of_device_id qcom_hwspinlock_of_match[] = {
> { .compatible = "qcom,sfpb-mutex", .data = &of_sfpb_mutex },
> { .compatible = "qcom,tcsr-mutex", .data = &of_tcsr_mutex },
> { .compatible = "qcom,apq8084-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
> - { .compatible = "qcom,ipq6018-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
> { .compatible = "qcom,msm8226-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
> { .compatible = "qcom,msm8974-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
> { .compatible = "qcom,msm8994-tcsr-mutex", .data = &of_msm8226_tcsr_mutex },
prev parent reply other threads:[~2023-12-13 5:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 14:25 [PATCH 1/1] hwspinlock: qcom: fix tcsr data for ipq6018 Chukun Pan
2023-12-13 5:32 ` Vignesh Viswanathan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51133a78-43ca-46fb-8f5e-b3bfdaef9a79@quicinc.com \
--to=quic_viswanat@quicinc.com \
--cc=agross@kernel.org \
--cc=amadeus@jmu.edu.cn \
--cc=andersson@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).