Linux-remoteproc Archive mirror
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
	Tero Kristo <kristo@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Hari Nagalla <hnagalla@ti.com>,
	<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 3/9] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem
Date: Mon, 19 Aug 2024 10:54:11 -0500	[thread overview]
Message-ID: <98d65c2e-f5a2-4894-b76d-6fa0fb8b6daf@ti.com> (raw)
In-Reply-To: <f529c5ef-f61c-4c8b-a589-652aca162f07@kernel.org>

On 8/19/24 10:39 AM, Krzysztof Kozlowski wrote:
> On 19/08/2024 17:32, Mathieu Poirier wrote:
> 
>>>>> Please remove.
>>>> Forget this comment since it would cause an error in __rproc_detach().
>>>>
>>>>> Other than the above I'm good with this driver.  That said I can't move forward
>>>>> without a nod from the DT crew.  I also noticed a fair amount of code
>>>>> duplication with the k3_r5 and k3_dsp drivers.  Dealing with that should not be
>>>>> part of the current work but will need to be done before another k3 driver can
>>>>> be merged.
>>>>>
>>>
>>>> The above still apply though.
>>>
>>> Me or Nishanth will pick up the SoC DT patches via TI SoC tree, once the
>>> driver patches are merged. Feel free to ignore those but queue
>>> dt-bindings (already has DT maintainers ack) and driver patches via
>>> rproc tree.
>>>
>>
>> Can you provide a link where the DT maintainers have acknowledged the bindings?
> 
> The reviewed-by tag serves as acknowledgment as well and the binding
> patch has it. Conor gave it on some earlier version of the patchset. I
> did not check if there were any significant changes in the meantime, though.
> 

Was reviewed in v8:
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240424190612.17349-2-afd@ti.com/#3302840

If there was any significant changes since I would have dropped the tag.

Andrew

> 
> Best regards,
> Krzysztof
> 

  reply	other threads:[~2024-08-19 15:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02 15:21 [PATCH v11 0/9] TI K3 M4F support on AM62 and AM64 SoCs Andrew Davis
2024-08-02 15:21 ` [PATCH v11 1/9] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs Andrew Davis
2024-08-02 15:21 ` [PATCH v11 2/9] remoteproc: k3: Factor out TI-SCI processor control OF get function Andrew Davis
2024-08-19  8:49   ` Wadim Egorov
2024-08-02 15:21 ` [PATCH v11 3/9] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem Andrew Davis
2024-08-15 16:46   ` Mathieu Poirier
2024-08-16 14:36     ` Mathieu Poirier
2024-08-19  8:32       ` Vignesh Raghavendra
2024-08-19 15:32         ` Mathieu Poirier
2024-08-19 15:39           ` Krzysztof Kozlowski
2024-08-19 15:54             ` Andrew Davis [this message]
2024-08-21 17:12               ` Mathieu Poirier
2024-08-19  8:47   ` Wadim Egorov
2024-08-02 15:21 ` [PATCH v11 4/9] arm64: dts: ti: k3-am62: Add M4F remoteproc node Andrew Davis
2024-08-19  8:48   ` Wadim Egorov
2024-08-02 15:21 ` [PATCH v11 5/9] arm64: dts: ti: k3-am625-sk: " Andrew Davis
2024-08-02 15:21 ` [PATCH v11 6/9] arm64: dts: ti: k3-am64: " Andrew Davis
2024-08-02 15:21 ` [PATCH v11 7/9] arm64: dts: ti: k3-am642-sk: " Andrew Davis
2024-08-02 15:21 ` [PATCH v11 8/9] arm64: dts: ti: k3-am642-evm: " Andrew Davis
2024-08-02 15:21 ` [PATCH v11 9/9] arm64: defconfig: Enable TI K3 M4 remoteproc driver Andrew Davis
2025-01-08  7:31   ` Daniel Schultz
2024-08-19  8:33 ` [PATCH v11 0/9] TI K3 M4F support on AM62 and AM64 SoCs Wadim Egorov
2025-01-08 15:49 ` (subset) " Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98d65c2e-f5a2-4894-b76d-6fa0fb8b6daf@ti.com \
    --to=afd@ti.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hnagalla@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=nm@ti.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).