From: Daniel Baluta <daniel.baluta@gmail.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
andersson@kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
iuliana.prodan@nxp.com, peng.fan@nxp.com,
Alexandru Lastur <alexandru.lastur@nxp.com>,
arnaud.pouliquen@foss.st.com
Subject: Re: [RFC PATCH] remoteproc: core: Add support for predefined notifyids
Date: Wed, 30 Oct 2024 16:04:00 +0200 [thread overview]
Message-ID: <CAEnQRZDoYvK-YXLjqbXsRAWDkHrWNOoR1OCCWxs+AfNUDuPB_w@mail.gmail.com> (raw)
In-Reply-To: <ZxkW9SUr91PyH9c/@p14s>
On Wed, Oct 23, 2024 at 6:32 PM Mathieu Poirier
<mathieu.poirier@linaro.org> wrote:
>
> Hello Daniel,
>
> On Fri, Oct 18, 2024 at 02:09:29PM +0300, Daniel Baluta wrote:
> > Currently we generate notifyids in the linux kernel and override
> > those found in rsc_table.
> >
> > This doesn't play well with users expecting to use the exact ids
> > from rsc_table.
> >
> > So, use predefined notifyids found in rsc_table if any. Otherwise,
> > let Linux generate the ids as before.
> >
> > Keypoint is we also define an invalid notifid as 0xFFFFFFFFU. This
> > should be placed as notifids if users want Linux to generate the ids.
> >
> > Signed-off-by: Alexandru Lastur <alexandru.lastur@nxp.com>
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> > drivers/remoteproc/remoteproc_core.c | 14 ++++++++++++--
> > include/linux/remoteproc.h | 1 +
> > 2 files changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > index f276956f2c5c..9f00fe16da38 100644
> > --- a/drivers/remoteproc/remoteproc_core.c
> > +++ b/drivers/remoteproc/remoteproc_core.c
> > @@ -332,6 +332,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
> > int ret, notifyid;
> > struct rproc_mem_entry *mem;
> > size_t size;
> > + int start, end;
> >
> > /* actual size of vring (in bytes) */
> > size = PAGE_ALIGN(vring_size(rvring->num, rvring->align));
> > @@ -363,9 +364,18 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
> > /*
> > * Assign an rproc-wide unique index for this vring
> > * TODO: assign a notifyid for rvdev updates as well
> > - * TODO: support predefined notifyids (via resource table)
> > */
> > - ret = idr_alloc(&rproc->notifyids, rvring, 0, 0, GFP_KERNEL);
> > +
> > + start = 0;
> > + end = 0;
> > +
> > + /* use id if specified in rsc table */
> > + if (rsc->vring[i].notifyid != RSC_INVALID_NOTIFYID) {
> > + start = rsc->vring[i].notifyid;
> > + end = start + 1;
> > + }
>
> This will likely introduce a backward compatibility issue where anyone that
> has more than one vring and set their notifyids to anything else than 0xFFFFFFFF
> in the resource table will see a boot failure.
>
> A while back the openAMP group started discussions on using the configuration
> space of a virtio device to enhance device discovery, with exactly this kind of
> use case in mind. I think it is the only way to move forward with this
> feature, though it is a big job that requires a lot of community interactions.
I also found this attempt few years ago:
https://lkml.iu.edu/hypermail/linux/kernel/2001.2/05248.html
I think the best way to go is to bump the resource table version and support
the old behavior for v1 and the new behavior for the new version
(which should be v2).
We will be back next week with a patch to express this.
thanks,
Daniel.
prev parent reply other threads:[~2024-10-30 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 11:09 [RFC PATCH] remoteproc: core: Add support for predefined notifyids Daniel Baluta
2024-10-23 15:32 ` Mathieu Poirier
2024-10-25 20:38 ` Arnaud POULIQUEN
2024-10-30 14:04 ` Daniel Baluta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEnQRZDoYvK-YXLjqbXsRAWDkHrWNOoR1OCCWxs+AfNUDuPB_w@mail.gmail.com \
--to=daniel.baluta@gmail.com \
--cc=alexandru.lastur@nxp.com \
--cc=andersson@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=daniel.baluta@nxp.com \
--cc=imx@lists.linux.dev \
--cc=iuliana.prodan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).