From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: jason-ch chen <jason-ch.chen@mediatek.corp-partner.google.com>,
Bjorn Andersson <andersson@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Jason Chen <Jason-ch.Chen@mediatek.com>
Subject: Re: [PATCH] remoteproc: mediatek: Increase MT8188 SCP core0 DRAM size
Date: Mon, 10 Jun 2024 10:34:16 -0600 [thread overview]
Message-ID: <ZmcrCLOCo0Q0W6AU@p14s> (raw)
In-Reply-To: <bc12b046-d2fb-48ae-bd5b-a6ef6cc78c07@collabora.com>
On Thu, Jun 06, 2024 at 01:00:11PM +0200, AngeloGioacchino Del Regno wrote:
> Il 06/06/24 11:06, jason-ch chen ha scritto:
> > From: Jason Chen <Jason-ch.Chen@mediatek.com>
> >
> > Increase MT8188 SCP core0 DRAM size for HEVC driver.
This is telling me _what_ gets done rather than _why_ it gets done.
> >
>
> ....so the second core only gets a maximum of 0x200000 of SRAM?
> I'm not sure how useful is the secondary SCP core, at this point, with so little
> available SRAM but... okay, as you wish.
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
>
> > Signed-off-by: Jason Chen <Jason-ch.Chen@mediatek.com>
> > ---
> > drivers/remoteproc/mtk_scp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> > index b885a9a041e4..2119fc62c3f2 100644
> > --- a/drivers/remoteproc/mtk_scp.c
> > +++ b/drivers/remoteproc/mtk_scp.c
> > @@ -1390,7 +1390,7 @@ static const struct mtk_scp_sizes_data default_scp_sizes = {
> > };
> > static const struct mtk_scp_sizes_data mt8188_scp_sizes = {
> > - .max_dram_size = 0x500000,
> > + .max_dram_size = 0x800000,
Do you require to fix a "reserved-memory" node in a device tree file to account
for this?
Thanks,
Mathieu
> > .ipi_share_buffer_size = 600,
> > };
>
>
next prev parent reply other threads:[~2024-06-10 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 9:06 [PATCH] remoteproc: mediatek: Increase MT8188 SCP core0 DRAM size jason-ch chen
2024-06-06 11:00 ` AngeloGioacchino Del Regno
2024-06-10 16:34 ` Mathieu Poirier [this message]
2024-06-27 2:31 ` Jason-ch Chen (陳建豪)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmcrCLOCo0Q0W6AU@p14s \
--to=mathieu.poirier@linaro.org \
--cc=Jason-ch.Chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=jason-ch.chen@mediatek.corp-partner.google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).