[PATCH v2 0/5] Add MPSS remoteproc support for SDX75

Linux-remoteproc Archive mirror
 help / color / mirror / Atom feed

* [PATCH v2 0/5] Add MPSS remoteproc support for SDX75
@ 2024-06-17  9:34 Naina Mehta
  2024-06-17  9:34 ` [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS Naina Mehta
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Naina Mehta @ 2024-06-17  9:34 UTC (permalink / raw)
  To: andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	konrad.dybcio, manivannan.sadhasivam
  Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
	quic_nainmeht

Add modem support to SDX75 using the PAS remoteproc driver.
Also, add qlink_logging memory region and split MPSS DSM
region into 2 separate regions.

These patches were co-authored by Rohit Agarwal while at
Qualcomm.

Changes in v2:
 - Added missing binding for SDX75 to allOf constraints.
 - Updated reserved memory node names to remove underscores.
 - Link to v1: https://lore.kernel.org/all/20240606143858.4026-1-quic_nainmeht@quicinc.com/

Naina Mehta (5):
  dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS
  remoteproc: qcom: pas: Add SDX75 remoteproc support
  arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for
    mpss
  arm64: dts: qcom: sdx75: Add remoteproc node
  arm64: dts: qcom: sdx75-idp: enable MPSS remoteproc node

 .../bindings/remoteproc/qcom,sm8550-pas.yaml  |  3 +
 arch/arm64/boot/dts/qcom/sdx75-idp.dts        |  6 ++
 arch/arm64/boot/dts/qcom/sdx75.dtsi           | 64 +++++++++++++++++--
 drivers/remoteproc/qcom_q6v5_pas.c            |  1 +
 4 files changed, 70 insertions(+), 4 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS
  2024-06-17  9:34 [PATCH v2 0/5] Add MPSS remoteproc support for SDX75 Naina Mehta
@ 2024-06-17  9:34 ` Naina Mehta
  2024-06-17 12:22   ` Krzysztof Kozlowski
  2024-06-17  9:34 ` [PATCH v2 2/5] remoteproc: qcom: pas: Add SDX75 remoteproc support Naina Mehta
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Naina Mehta @ 2024-06-17  9:34 UTC (permalink / raw)
  To: andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	konrad.dybcio, manivannan.sadhasivam
  Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
	quic_nainmeht

Document the MPSS Peripheral Authentication Service on SDX75 platform.

Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
---
 .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml        | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index 73fda7565cd1..d7fad7b3c2c6 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -16,6 +16,7 @@ description:
 properties:
   compatible:
     enum:
+      - qcom,sdx75-mpss-pas
       - qcom,sm8550-adsp-pas
       - qcom,sm8550-cdsp-pas
       - qcom,sm8550-mpss-pas
@@ -113,6 +114,7 @@ allOf:
       properties:
         compatible:
           enum:
+            - qcom,sdx75-mpss-pas
             - qcom,sm8650-mpss-pas
     then:
       properties:
@@ -146,6 +148,7 @@ allOf:
       properties:
         compatible:
           enum:
+            - qcom,sdx75-mpss-pas
             - qcom,sm8550-mpss-pas
             - qcom,sm8650-mpss-pas
     then:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS
  2024-06-17  9:34 ` [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS Naina Mehta
@ 2024-06-17 12:22   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-17 12:22 UTC (permalink / raw)
  To: Naina Mehta, andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	konrad.dybcio, manivannan.sadhasivam
  Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel

On 17/06/2024 11:34, Naina Mehta wrote:
> Document the MPSS Peripheral Authentication Service on SDX75 platform.
> 
> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 2/5] remoteproc: qcom: pas: Add SDX75 remoteproc support
  2024-06-17  9:34 [PATCH v2 0/5] Add MPSS remoteproc support for SDX75 Naina Mehta
  2024-06-17  9:34 ` [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS Naina Mehta
@ 2024-06-17  9:34 ` Naina Mehta
  2024-06-17  9:34 ` [PATCH v2 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss Naina Mehta
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 10+ messages in thread
From: Naina Mehta @ 2024-06-17  9:34 UTC (permalink / raw)
  To: andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	konrad.dybcio, manivannan.sadhasivam
  Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
	quic_nainmeht

Add MPSS Peripheral Authentication Service support for SDX75 platform.

Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
---
 drivers/remoteproc/qcom_q6v5_pas.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index 8458bcfe9e19..833e2f9c2c5e 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -1343,6 +1343,7 @@ static const struct of_device_id adsp_of_match[] = {
 	{ .compatible = "qcom,sdm845-cdsp-pas", .data = &sdm845_cdsp_resource_init},
 	{ .compatible = "qcom,sdm845-slpi-pas", .data = &sdm845_slpi_resource_init},
 	{ .compatible = "qcom,sdx55-mpss-pas", .data = &sdx55_mpss_resource},
+	{ .compatible = "qcom,sdx75-mpss-pas", .data = &sm8650_mpss_resource},
 	{ .compatible = "qcom,sm6115-adsp-pas", .data = &adsp_resource_init},
 	{ .compatible = "qcom,sm6115-cdsp-pas", .data = &cdsp_resource_init},
 	{ .compatible = "qcom,sm6115-mpss-pas", .data = &sc8180x_mpss_resource},
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss
  2024-06-17  9:34 [PATCH v2 0/5] Add MPSS remoteproc support for SDX75 Naina Mehta
  2024-06-17  9:34 ` [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS Naina Mehta
  2024-06-17  9:34 ` [PATCH v2 2/5] remoteproc: qcom: pas: Add SDX75 remoteproc support Naina Mehta
@ 2024-06-17  9:34 ` Naina Mehta
  2024-06-17 17:33   ` Konrad Dybcio
  2024-06-17  9:34 ` [PATCH v2 4/5] arm64: dts: qcom: sdx75: Add remoteproc node Naina Mehta
  2024-06-17  9:34 ` [PATCH v2 5/5] arm64: dts: qcom: sdx75-idp: enable MPSS " Naina Mehta
  4 siblings, 1 reply; 10+ messages in thread
From: Naina Mehta @ 2024-06-17  9:34 UTC (permalink / raw)
  To: andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	konrad.dybcio, manivannan.sadhasivam
  Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
	quic_nainmeht

The qlink_logging memory region is also used by the modem firmware,
add it to reserved memory regions.
Also split MPSS DSM region into 2 separate regions.

Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sdx75.dtsi | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
index 9b93f6501d55..afe84270b84c 100644
--- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
@@ -366,7 +366,12 @@ uefi_log_mem: uefi-log@87f75000 {
 			no-map;
 		};
 
-		qdss_mem: qdss@88800000 {
+		qdss_mem: qdss@88500000 {
+			reg = <0x0 0x88500000 0x0 0x300000>;
+			no-map;
+		};
+
+		qlink_logging_mem: qlink-logging@88800000 {
 			reg = <0x0 0x88800000 0x0 0x300000>;
 			no-map;
 		};
@@ -377,18 +382,22 @@ audio_heap_mem: audio-heap@88b00000 {
 			no-map;
 		};
 
-		mpss_dsmharq_mem: mpss-dsmharq@88f00000 {
-			reg = <0x0 0x88f00000 0x0 0x5080000>;
+		mpss_dsm_mem_2: mpss-dsm-2@88f00000 {
+			reg = <0x0 0x88f00000 0x0 0x2500000>;
 			no-map;
 		};
 
+		mpss_dsm_mem: mpss-dsm@8b400000 {
+			reg = <0x0 0x8b400000 0x0 0x2b80000>;
+		};
+
 		q6_mpss_dtb_mem: q6-mpss-dtb@8df80000 {
 			reg = <0x0 0x8df80000 0x0 0x80000>;
 			no-map;
 		};
 
 		mpssadsp_mem: mpssadsp@8e000000 {
-			reg = <0x0 0x8e000000 0x0 0xf400000>;
+			reg = <0x0 0x8e000000 0x0 0xf100000>;
 			no-map;
 		};
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss
  2024-06-17  9:34 ` [PATCH v2 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss Naina Mehta
@ 2024-06-17 17:33   ` Konrad Dybcio
  0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2024-06-17 17:33 UTC (permalink / raw)
  To: Naina Mehta, andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	manivannan.sadhasivam
  Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel



On 6/17/24 11:34, Naina Mehta wrote:
> The qlink_logging memory region is also used by the modem firmware,
> add it to reserved memory regions.
> Also split MPSS DSM region into 2 separate regions.
> 
> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
> ---

The commit message is very misleading.. You're not adding
qlink_logging, you're renaming qdss@8800000 to qlink_logging.

Then, you add qdss_mem @ 88500000 and split the dsmharq_mem into two
and shrink mpssadsp_mem.

Please rewrite the commit message.

Konrad

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 4/5] arm64: dts: qcom: sdx75: Add remoteproc node
  2024-06-17  9:34 [PATCH v2 0/5] Add MPSS remoteproc support for SDX75 Naina Mehta
                   ` (2 preceding siblings ...)
  2024-06-17  9:34 ` [PATCH v2 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss Naina Mehta
@ 2024-06-17  9:34 ` Naina Mehta
  2024-06-17 10:02   ` Dmitry Baryshkov
  2024-06-17  9:34 ` [PATCH v2 5/5] arm64: dts: qcom: sdx75-idp: enable MPSS " Naina Mehta
  4 siblings, 1 reply; 10+ messages in thread
From: Naina Mehta @ 2024-06-17  9:34 UTC (permalink / raw)
  To: andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	konrad.dybcio, manivannan.sadhasivam
  Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
	quic_nainmeht

Add MPSS remoteproc node for SDX75 SoC.

Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sdx75.dtsi | 47 +++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
index afe84270b84c..db042ec2640e 100644
--- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
@@ -890,6 +890,53 @@ tcsr: syscon@1fc0000 {
 			reg = <0x0 0x01fc0000 0x0 0x30000>;
 		};
 
+		remoteproc_mpss: remoteproc@4080000 {
+			compatible = "qcom,sdx75-mpss-pas";
+			reg = <0 0x04080000 0 0x4040>;
+
+			interrupts-extended = <&intc GIC_SPI 250 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_modem_in 0 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_modem_in 1 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_modem_in 2 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_modem_in 3 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_modem_in 7 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "wdog",
+					  "fatal",
+					  "ready",
+					  "handover",
+					  "stop-ack",
+					  "shutdown-ack";
+
+			clocks = <&rpmhcc RPMH_CXO_CLK>;
+			clock-names = "xo";
+
+			power-domains = <&rpmhpd RPMHPD_CX>,
+					<&rpmhpd RPMHPD_MSS>;
+			power-domain-names = "cx",
+					     "mss";
+
+			memory-region = <&mpssadsp_mem>, <&q6_mpss_dtb_mem>,
+					<&mpss_dsm_mem>, <&mpss_dsm_mem_2>,
+					<&qlink_logging_mem>;
+
+			qcom,qmp = <&aoss_qmp>;
+
+			qcom,smem-states = <&smp2p_modem_out 0>;
+			qcom,smem-state-names = "stop";
+
+			status = "disabled";
+
+			glink-edge {
+				interrupts-extended = <&ipcc IPCC_CLIENT_MPSS
+							     IPCC_MPROC_SIGNAL_PING
+							     IRQ_TYPE_EDGE_RISING>;
+				mboxes = <&ipcc IPCC_CLIENT_MPSS
+						IPCC_MPROC_SIGNAL_PING>;
+				label = "mpss";
+				qcom,remote-pid = <1>;
+			};
+		};
+
 		sdhc: mmc@8804000 {
 			compatible = "qcom,sdx75-sdhci", "qcom,sdhci-msm-v5";
 			reg = <0x0 0x08804000 0x0 0x1000>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 4/5] arm64: dts: qcom: sdx75: Add remoteproc node
  2024-06-17  9:34 ` [PATCH v2 4/5] arm64: dts: qcom: sdx75: Add remoteproc node Naina Mehta
@ 2024-06-17 10:02   ` Dmitry Baryshkov
  0 siblings, 0 replies; 10+ messages in thread
From: Dmitry Baryshkov @ 2024-06-17 10:02 UTC (permalink / raw)
  To: Naina Mehta
  Cc: andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	konrad.dybcio, manivannan.sadhasivam, linux-arm-msm,
	linux-remoteproc, devicetree, linux-kernel

On Mon, Jun 17, 2024 at 03:04:27PM GMT, Naina Mehta wrote:
> Add MPSS remoteproc node for SDX75 SoC.
> 
> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sdx75.dtsi | 47 +++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 5/5] arm64: dts: qcom: sdx75-idp: enable MPSS remoteproc node
  2024-06-17  9:34 [PATCH v2 0/5] Add MPSS remoteproc support for SDX75 Naina Mehta
                   ` (3 preceding siblings ...)
  2024-06-17  9:34 ` [PATCH v2 4/5] arm64: dts: qcom: sdx75: Add remoteproc node Naina Mehta
@ 2024-06-17  9:34 ` Naina Mehta
  2024-06-17 10:02   ` Dmitry Baryshkov
  4 siblings, 1 reply; 10+ messages in thread
From: Naina Mehta @ 2024-06-17  9:34 UTC (permalink / raw)
  To: andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	konrad.dybcio, manivannan.sadhasivam
  Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
	quic_nainmeht

Enable MPSS remoteproc node on sdx75-idp platform.

Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sdx75-idp.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
index fde16308c7e2..f1bbe7ab01ab 100644
--- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
@@ -282,6 +282,12 @@ &qupv3_id_0 {
 	status = "okay";
 };
 
+&remoteproc_mpss {
+	firmware-name = "qcom/sdx75/modem.mbn",
+			"qcom/sdx75/modem_dtb.mbn";
+	status = "okay";
+};
+
 &sdhc {
 	cd-gpios = <&tlmm 103 GPIO_ACTIVE_LOW>;
 	vmmc-supply = <&reg_2v95_vdd>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 5/5] arm64: dts: qcom: sdx75-idp: enable MPSS remoteproc node
  2024-06-17  9:34 ` [PATCH v2 5/5] arm64: dts: qcom: sdx75-idp: enable MPSS " Naina Mehta
@ 2024-06-17 10:02   ` Dmitry Baryshkov
  0 siblings, 0 replies; 10+ messages in thread
From: Dmitry Baryshkov @ 2024-06-17 10:02 UTC (permalink / raw)
  To: Naina Mehta
  Cc: andersson, mathieu.poirier, robh, krzk+dt, conor+dt,
	konrad.dybcio, manivannan.sadhasivam, linux-arm-msm,
	linux-remoteproc, devicetree, linux-kernel

On Mon, Jun 17, 2024 at 03:04:28PM GMT, Naina Mehta wrote:
> Enable MPSS remoteproc node on sdx75-idp platform.
> 
> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sdx75-idp.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-06-17 17:33 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-17  9:34 [PATCH v2 0/5] Add MPSS remoteproc support for SDX75 Naina Mehta
2024-06-17  9:34 ` [PATCH v2 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS Naina Mehta
2024-06-17 12:22   ` Krzysztof Kozlowski
2024-06-17  9:34 ` [PATCH v2 2/5] remoteproc: qcom: pas: Add SDX75 remoteproc support Naina Mehta
2024-06-17  9:34 ` [PATCH v2 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss Naina Mehta
2024-06-17 17:33   ` Konrad Dybcio
2024-06-17  9:34 ` [PATCH v2 4/5] arm64: dts: qcom: sdx75: Add remoteproc node Naina Mehta
2024-06-17 10:02   ` Dmitry Baryshkov
2024-06-17  9:34 ` [PATCH v2 5/5] arm64: dts: qcom: sdx75-idp: enable MPSS " Naina Mehta
2024-06-17 10:02   ` Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).