From: Vignesh Raghavendra <vigneshr@ti.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>, Andrew Davis <afd@ti.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Nishanth Menon <nm@ti.com>,
Tero Kristo <kristo@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Hari Nagalla <hnagalla@ti.com>,
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 3/9] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem
Date: Mon, 19 Aug 2024 14:02:31 +0530 [thread overview]
Message-ID: <e5140426-7e69-41b0-858f-16f83eed871a@ti.com> (raw)
In-Reply-To: <Zr9j5HBjRqqRIoaD@p14s>
[...]
Hi Mathieu
On 16/08/24 20:06, Mathieu Poirier wrote:
>>> +/*
>>> + * Attach to a running M4 remote processor (IPC-only mode)
>>> + *
>>> + * The remote processor is already booted, so there is no need to issue any
>>> + * TI-SCI commands to boot the M4 core. This callback is used only in IPC-only
>>> + * mode.
>>> + */
>>> +static int k3_m4_rproc_attach(struct rproc *rproc)
>>> +{
>>> + struct k3_m4_rproc *kproc = rproc->priv;
>>> + int ret;
>>> +
>>> + ret = k3_m4_rproc_ping_mbox(kproc);
>>> + if (ret)
>>> + return ret;
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +/*
>>> + * Detach from a running M4 remote processor (IPC-only mode)
>>> + *
>>> + * This rproc detach callback performs the opposite operation to attach
>>> + * callback, the M4 core is not stopped and will be left to continue to
>>> + * run its booted firmware. This callback is invoked only in IPC-only mode.
>>> + */
>>> +static int k3_m4_rproc_detach(struct rproc *rproc)
>>> +{
>>> + return 0;
>>> +}
>> Please remove.
> Forget this comment since it would cause an error in __rproc_detach().
>
>> Other than the above I'm good with this driver. That said I can't move forward
>> without a nod from the DT crew. I also noticed a fair amount of code
>> duplication with the k3_r5 and k3_dsp drivers. Dealing with that should not be
>> part of the current work but will need to be done before another k3 driver can
>> be merged.
>>
> The above still apply though.
Me or Nishanth will pick up the SoC DT patches via TI SoC tree, once the
driver patches are merged. Feel free to ignore those but queue
dt-bindings (already has DT maintainers ack) and driver patches via
rproc tree.
--
Regards
Vignesh
next prev parent reply other threads:[~2024-08-19 8:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 15:21 [PATCH v11 0/9] TI K3 M4F support on AM62 and AM64 SoCs Andrew Davis
2024-08-02 15:21 ` [PATCH v11 1/9] dt-bindings: remoteproc: k3-m4f: Add K3 AM64x SoCs Andrew Davis
2024-08-02 15:21 ` [PATCH v11 2/9] remoteproc: k3: Factor out TI-SCI processor control OF get function Andrew Davis
2024-08-19 8:49 ` Wadim Egorov
2024-08-02 15:21 ` [PATCH v11 3/9] remoteproc: k3-m4: Add a remoteproc driver for M4F subsystem Andrew Davis
2024-08-15 16:46 ` Mathieu Poirier
2024-08-16 14:36 ` Mathieu Poirier
2024-08-19 8:32 ` Vignesh Raghavendra [this message]
2024-08-19 15:32 ` Mathieu Poirier
2024-08-19 15:39 ` Krzysztof Kozlowski
2024-08-19 15:54 ` Andrew Davis
2024-08-21 17:12 ` Mathieu Poirier
2024-08-19 8:47 ` Wadim Egorov
2024-08-02 15:21 ` [PATCH v11 4/9] arm64: dts: ti: k3-am62: Add M4F remoteproc node Andrew Davis
2024-08-19 8:48 ` Wadim Egorov
2024-08-02 15:21 ` [PATCH v11 5/9] arm64: dts: ti: k3-am625-sk: " Andrew Davis
2024-08-02 15:21 ` [PATCH v11 6/9] arm64: dts: ti: k3-am64: " Andrew Davis
2024-08-02 15:21 ` [PATCH v11 7/9] arm64: dts: ti: k3-am642-sk: " Andrew Davis
2024-08-02 15:21 ` [PATCH v11 8/9] arm64: dts: ti: k3-am642-evm: " Andrew Davis
2024-08-02 15:21 ` [PATCH v11 9/9] arm64: defconfig: Enable TI K3 M4 remoteproc driver Andrew Davis
2025-01-08 7:31 ` Daniel Schultz
2024-08-19 8:33 ` [PATCH v11 0/9] TI K3 M4F support on AM62 and AM64 SoCs Wadim Egorov
2025-01-08 15:49 ` (subset) " Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5140426-7e69-41b0-858f-16f83eed871a@ti.com \
--to=vigneshr@ti.com \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).