From: Hari Nagalla <hnagalla@ti.com>
To: Andrew Davis <afd@ti.com>, Jassi Brar <jassisinghbrar@gmail.com>,
Nick Saulnier <nsaulnier@ti.com>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 12/13] mailbox: omap: Reverse FIFO busy check logic
Date: Mon, 1 Apr 2024 18:31:29 -0500 [thread overview]
Message-ID: <fb0ddca3-3b74-8225-914e-d1799f6c3ca3@ti.com> (raw)
In-Reply-To: <20240325172045.113047-13-afd@ti.com>
On 3/25/24 12:20, Andrew Davis wrote:
>
> static int omap_mbox_chan_send_noirq(struct omap_mbox *mbox, u32 msg)
> {
> - int ret = -EBUSY;
> + if (mbox_fifo_full(mbox))
> + return -EBUSY;
>
> - if (!mbox_fifo_full(mbox)) {
> - omap_mbox_enable_irq(mbox, IRQ_RX);
> - mbox_fifo_write(mbox, msg);
> - ret = 0;
> - omap_mbox_disable_irq(mbox, IRQ_RX);
> + omap_mbox_enable_irq(mbox, IRQ_RX);
> + mbox_fifo_write(mbox, msg);
> + omap_mbox_disable_irq(mbox, IRQ_RX);
>
> - /* we must read and ack the interrupt directly from here */
> - mbox_fifo_read(mbox);
> - ack_mbox_irq(mbox, IRQ_RX);
> - }
> + /* we must read and ack the interrupt directly from here */
> + mbox_fifo_read(mbox);
> + ack_mbox_irq(mbox, IRQ_RX);
>
> - return ret;
> + return 0;
> }
Is n't the interrupt supposed to be IRQ_TX above? i.e TX ready signal?
next prev parent reply other threads:[~2024-04-01 23:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 17:20 [PATCH 00/13] OMAP mailbox FIFO removal Andrew Davis
2024-03-25 17:20 ` [PATCH 01/13] mailbox: omap: Remove unused omap_mbox_{enable,disable}_irq() functions Andrew Davis
2024-03-25 17:20 ` [PATCH 02/13] mailbox: omap: Remove unused omap_mbox_request_channel() function Andrew Davis
2024-03-25 17:20 ` [PATCH 03/13] mailbox: omap: Move omap_mbox_irq_t into driver Andrew Davis
2024-03-25 17:20 ` [PATCH 04/13] mailbox: omap: Move fifo size check to point of use Andrew Davis
2024-03-25 17:20 ` [PATCH 05/13] mailbox: omap: Remove unneeded header omap-mailbox.h Andrew Davis
2024-03-25 17:20 ` [PATCH 06/13] mailbox: omap: Remove device class Andrew Davis
2024-03-25 17:20 ` [PATCH 07/13] mailbox: omap: Use devm_pm_runtime_enable() helper Andrew Davis
2024-03-25 17:20 ` [PATCH 08/13] mailbox: omap: Merge mailbox child node setup loops Andrew Davis
2024-03-25 17:20 ` [PATCH 09/13] mailbox: omap: Use function local struct mbox_controller Andrew Davis
2024-03-25 17:20 ` [PATCH 10/13] mailbox: omap: Use mbox_controller channel list directly Andrew Davis
2024-03-25 17:20 ` [PATCH 11/13] mailbox: omap: Remove mbox_chan_to_omap_mbox() Andrew Davis
2024-03-25 17:20 ` [PATCH 12/13] mailbox: omap: Reverse FIFO busy check logic Andrew Davis
2024-04-01 23:31 ` Hari Nagalla [this message]
2024-04-01 23:47 ` Andrew Davis
2024-03-25 17:20 ` [PATCH 13/13] mailbox: omap: Remove kernel FIFO message queuing Andrew Davis
2024-04-01 23:39 ` Hari Nagalla
2024-04-01 23:50 ` Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb0ddca3-3b74-8225-914e-d1799f6c3ca3@ti.com \
--to=hnagalla@ti.com \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nsaulnier@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).