From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-media@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Sakari Ailus <sakari.ailus@iki.fi>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dafna Hirschfeld <dafna@fastmail.com>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 3/3] media: rkisp1: Mark subdev state pointers as const
Date: Fri, 10 May 2024 09:36:53 +0300 [thread overview]
Message-ID: <1fc8609d-a85d-461a-acbb-50d6637d79b8@ideasonboard.com> (raw)
In-Reply-To: <20240508214045.24716-4-laurent.pinchart+renesas@ideasonboard.com>
On 09/05/2024 00:40, Laurent Pinchart wrote:
> Several subdev state pointers are used to access the state read-only.
> Mark them as const.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 8 ++++----
> drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
> index e45a213baf49..91301d17d356 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
> @@ -173,7 +173,7 @@ static void rkisp1_gasket_disable(struct rkisp1_device *rkisp1)
> * or at the frame end interrupt
> */
> static void rkisp1_config_ism(struct rkisp1_isp *isp,
> - struct v4l2_subdev_state *sd_state)
> + const struct v4l2_subdev_state *sd_state)
> {
> const struct v4l2_rect *src_crop =
> v4l2_subdev_state_get_crop(sd_state,
> @@ -201,7 +201,7 @@ static void rkisp1_config_ism(struct rkisp1_isp *isp,
> * configure ISP blocks with input format, size......
> */
> static int rkisp1_config_isp(struct rkisp1_isp *isp,
> - struct v4l2_subdev_state *sd_state,
> + const struct v4l2_subdev_state *sd_state,
> enum v4l2_mbus_type mbus_type, u32 mbus_flags)
> {
> struct rkisp1_device *rkisp1 = isp->rkisp1;
> @@ -309,7 +309,7 @@ static int rkisp1_config_isp(struct rkisp1_isp *isp,
> if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
> rkisp1_params_disable(&rkisp1->params);
> } else {
> - struct v4l2_mbus_framefmt *src_frm;
> + const struct v4l2_mbus_framefmt *src_frm;
>
> src_frm = v4l2_subdev_state_get_format(sd_state,
> RKISP1_ISP_PAD_SOURCE_VIDEO);
> @@ -429,7 +429,7 @@ static void rkisp1_config_clk(struct rkisp1_isp *isp)
> }
>
> static int rkisp1_isp_start(struct rkisp1_isp *isp,
> - struct v4l2_subdev_state *sd_state,
> + const struct v4l2_subdev_state *sd_state,
> struct media_pad *source)
> {
> struct rkisp1_device *rkisp1 = isp->rkisp1;
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c
> index 6f3931ca5b51..1fa991227fa9 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c
> @@ -135,11 +135,11 @@ static void rkisp1_dcrop_disable(struct rkisp1_resizer *rsz,
>
> /* configure dual-crop unit */
> static void rkisp1_dcrop_config(struct rkisp1_resizer *rsz,
> - struct v4l2_subdev_state *sd_state)
> + const struct v4l2_subdev_state *sd_state)
> {
> struct rkisp1_device *rkisp1 = rsz->rkisp1;
> - struct v4l2_mbus_framefmt *sink_fmt;
> - struct v4l2_rect *sink_crop;
> + const struct v4l2_mbus_framefmt *sink_fmt;
> + const struct v4l2_rect *sink_crop;
> u32 dc_ctrl;
>
> sink_crop = v4l2_subdev_state_get_crop(sd_state, RKISP1_RSZ_PAD_SINK);
> @@ -264,7 +264,7 @@ static void rkisp1_rsz_config_regs(struct rkisp1_resizer *rsz,
> }
>
> static void rkisp1_rsz_config(struct rkisp1_resizer *rsz,
> - struct v4l2_subdev_state *sd_state,
> + const struct v4l2_subdev_state *sd_state,
> enum rkisp1_shadow_regs_when when)
> {
> const struct rkisp1_rsz_yuv_mbus_info *sink_yuv_info, *src_yuv_info;
prev parent reply other threads:[~2024-05-10 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 21:40 [PATCH v4 0/3] media: v4l2-subdev: Support const-awareness in state accessors Laurent Pinchart
2024-05-08 21:40 ` [PATCH v4 1/3] media: v4l2-subdev: Fix v4l2_subdev_state_get_format() documentation Laurent Pinchart
2024-05-09 18:29 ` Sakari Ailus
2024-05-09 20:04 ` Laurent Pinchart
2024-05-08 21:40 ` [PATCH v4 2/3] media: v4l2-subdev: Provide const-aware subdev state accessors Laurent Pinchart
2024-05-08 21:40 ` [PATCH v4 3/3] media: rkisp1: Mark subdev state pointers as const Laurent Pinchart
2024-05-10 6:36 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fc8609d-a85d-461a-acbb-50d6637d79b8@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=dafna@fastmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).