From: Andrew Lunn <andrew@lunn.ch>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [net-next,v2] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN
Date: Wed, 8 May 2024 02:52:18 +0200 [thread overview]
Message-ID: <25f23887-061f-4ce6-a424-e5bf269cf8b5@lunn.ch> (raw)
In-Reply-To: <20240507201839.1763338-1-niklas.soderlund+renesas@ragnatech.se>
> +static int rtsn_probe(struct platform_device *pdev)
> +{
> + struct rtsn_private *priv;
> + struct net_device *ndev;
> + struct resource *res;
> + int ret;
> +
> + ndev = alloc_etherdev_mqs(sizeof(struct rtsn_private), TX_NUM_CHAINS,
...
> + ether_setup(ndev);
struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs,
unsigned int rxqs)
{
return alloc_netdev_mqs(sizeof_priv, "eth%d", NET_NAME_ENUM,
ether_setup, txqs, rxqs);
}
Notice the ether_setup here? I think you end up calling it twice.
Andrew
next prev parent reply other threads:[~2024-05-08 0:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 20:18 [net-next,v2] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN Niklas Söderlund
2024-05-07 20:57 ` Andrew Lunn
2024-05-07 21:50 ` Niklas Söderlund
2024-05-08 0:35 ` Andrew Lunn
2024-05-08 11:07 ` Niklas Söderlund
2024-05-08 0:52 ` Andrew Lunn [this message]
2024-05-08 11:03 ` Niklas Söderlund
2024-05-08 0:55 ` Andrew Lunn
2024-05-08 10:58 ` Niklas Söderlund
2024-05-08 12:33 ` Andrew Lunn
2024-05-08 12:55 ` Niklas Söderlund
2024-05-08 14:00 ` Andrew Lunn
2024-05-08 15:10 ` Niklas Söderlund
2024-05-08 15:29 ` Geert Uytterhoeven
2024-05-08 17:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25f23887-061f-4ce6-a424-e5bf269cf8b5@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).