From: Dirk Behme <dirk.behme@de.bosch.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [RFC PATCH 0/2] serial: sci: fix OOPS because of wrongly running hrtimer
Date: Wed, 17 Apr 2024 07:10:57 +0200 [thread overview]
Message-ID: <2606f543-0a2a-4184-a4b1-3c7664c8eeaf@de.bosch.com> (raw)
In-Reply-To: <20240416123545.7098-4-wsa+renesas () sang-engineering ! com>
Hi Wolfram,
On 16.04.2024 14:35, Wolfram Sang wrote:
> Dirk sent a very interesting bug report[1]. This series is what I found
> out by reviewing the driver. It is not tested yet because I couldn't
> trigger the code path yet. The console still works normally with these
> patches. Still, I am already curious in hearing your opinions, so here
> is what I have...
Many thanks for looking into this that fast! :)
Without much knowledge about this driver, from looking at your changes
they look quite good and reasonable! Therefore, if you like, you can add my
Acked-by: Dirk Behme <dirk.behme@de.bosch.com>
to both changes.
Many thanks again!
Dirk
> [1] https://lore.kernel.org/r/ee6c9e16-9f29-450e-81da-4a8dceaa8fc7@de.bosch.com
>
> Wolfram Sang (2):
> serial: sh-sci: start hrtimer after setting up DMA
> serial: sh-sci: always cancel hrtimer when DMA RX is invalidated
>
> drivers/tty/serial/sh-sci.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
next parent reply other threads:[~2024-04-17 5:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240416123545.7098-4-wsa+renesas () sang-engineering ! com>
2024-04-17 5:10 ` Dirk Behme [this message]
2024-04-16 12:35 [RFC PATCH 0/2] serial: sci: fix OOPS because of wrongly running hrtimer Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2606f543-0a2a-4184-a4b1-3c7664c8eeaf@de.bosch.com \
--to=dirk.behme@de.bosch.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).