From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword
Date: Tue, 23 Apr 2024 11:59:23 +0200 [thread overview]
Message-ID: <4c6d6957-3813-46d3-88de-ee64241bbe6f@kernel.org> (raw)
In-Reply-To: <CA+V-a8s1xDT7sGMpz_n45v9QzhpWUdJv9eXmUJoxPaJ69MiY7A@mail.gmail.com>
On 23/04/2024 09:21, Lad, Prabhakar wrote:
> Hi Krzysztof,
>
> Thank you for the review.
>
> On Tue, Apr 23, 2024 at 7:29 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 22/04/2024 23:30, Prabhakar wrote:
>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>>
>>> Drop 'items' keyword from compatible list which have single const value.
>>>
>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>> ---
>>> .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 ++++++------------
>>> 1 file changed, 6 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>>> index 29f2400247eb..90c8b1b727a8 100644
>>> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>>> @@ -12,16 +12,11 @@ maintainers:
>>> properties:
>>> compatible:
>>> oneOf:
>>> - - items:
>>> - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
>>> - - items:
>>> - - const: renesas,sdhi-r7s72100 # RZ/A1H
>>> - - items:
>>> - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
>>> - - items:
>>> - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
>>> - - items:
>>> - - const: renesas,sdhi-r8a7740 # R-Mobile A1
>>> + - const: renesas,sdhi-sh73a0 # R-Mobile APE6
>>> + - const: renesas,sdhi-r7s72100 # RZ/A1H
>>> + - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
>>> + - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
>>> + - const: renesas,sdhi-r8a7740 # R-Mobile A1
>>
>> That's just an enum.
>>
> Are you suggesting to group them into a single enum instead...?
Yes. That's preferred form, easier to read, because it clearly documents
that binding enumerates.
But just in case you start changing all const to enums: don't. Comment
is for this patch, since you already want to touch these things.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-23 9:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 21:30 [PATCH 0/6] Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs Prabhakar
2024-04-22 21:30 ` [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword Prabhakar
2024-04-23 6:29 ` Krzysztof Kozlowski
2024-04-23 7:21 ` Lad, Prabhakar
2024-04-23 9:59 ` Krzysztof Kozlowski [this message]
2024-04-23 11:26 ` Lad, Prabhakar
2024-04-22 21:30 ` [PATCH 2/6] dt-bindings: mmc: renesas,sdhi: Document RZ/G2L family compatibility Prabhakar
2024-04-23 6:29 ` Krzysztof Kozlowski
2024-04-22 21:30 ` [PATCH 3/6] mmc: renesas_sdhi: Add compatible string for RZ/G2L family, RZ/G3S, and RZ/V2M SoCs Prabhakar
2024-04-23 6:53 ` Geert Uytterhoeven
2024-04-23 7:11 ` Lad, Prabhakar
2024-04-22 21:30 ` [PATCH 4/6] arm64: dts: renesas: r9a09g011: Update fallback string for SDHI nodes Prabhakar
2024-04-24 14:40 ` Geert Uytterhoeven
2024-04-22 21:30 ` [PATCH 5/6] arm64: dts: renesas: rzg2l-family: " Prabhakar
2024-04-24 14:40 ` Geert Uytterhoeven
2024-04-22 21:30 ` [PATCH 6/6] arm64: dts: renesas: r9a08g045: " Prabhakar
2024-04-24 14:41 ` Geert Uytterhoeven
2024-04-23 6:57 ` [PATCH 0/6] Update compat strings for SD/MMC nodes on RZ/{G2L (family), G3S, V2M} SoCs Geert Uytterhoeven
2024-04-23 7:14 ` Lad, Prabhakar
2024-05-30 13:43 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c6d6957-3813-46d3-88de-ee64241bbe6f@kernel.org \
--to=krzk@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).