From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Jim Quinlan" <jim2101024@gmail.com>,
"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Will Deacon" <will@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Srikanth Thokala" <srikanth.thokala@intel.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bharat Kumar Gogada" <bharat.kumar.gogada@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Mark Kettenis" <kettenis@openbsd.org>,
"Tom Joseph" <tjoseph@cadence.com>,
"Ahmad Zainie" <wan.ahmad.zainie.wan.mohamad@intel.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Thippeswamy Havalige" <thippeswamy.havalige@amd.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 3/3] dt-bindings: PCI: host-bridges: switch from deprecated pci-bus.yaml
Date: Wed, 10 Apr 2024 13:11:09 -0500 [thread overview]
Message-ID: <CAL_JsqJM-DQvZ0fyJ17nY=vqtCRxyQwXGh6sbbAJ7rFjnAGrEA@mail.gmail.com> (raw)
In-Reply-To: <57827422-1042-4ef6-a11e-cb53fd930a41@linaro.org>
On Wed, Apr 10, 2024 at 1:00 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 10/04/2024 19:48, Rob Herring wrote:
> > On Sun, Apr 07, 2024 at 12:20:00PM +0200, Krzysztof Kozlowski wrote:
> >> dtschema package with core schemas deprecated pci-bus.yaml schema in
> >> favor of pci-host-bridge.yaml. Update all bindings to use the latter
> >> one.
> >>
> >> The difference between pci-bus.yaml and pci-host-bridge.yaml is only in
> >> lack of "reg" property defined by the latter, which should not have any
> >> effect here, because all these bindings define the "reg".
> >>
> >> The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml
> >> binding which have children nodes being also host bridges, apparently.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> ---
> >> Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/loongson.yaml | 2 +-
> >> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++--
> >> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 2 +-
> >> .../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 2 +-
> >> .../devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 2 +-
> >> .../devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/versatile.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml | 2 +-
> >> 25 files changed, 26 insertions(+), 26 deletions(-)
> >
> >
> >> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> >> index 61d027239910..5bbb4a3f3dbd 100644
> >> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> >> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> >> @@ -14,7 +14,7 @@ description: |+
> >> with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
> >>
> >> allOf:
> >> - - $ref: /schemas/pci/pci-bus.yaml#
> >> + - $ref: /schemas/pci/pci-host-bridge.yaml#
> >>
> >> properties:
> >> compatible:
> >> @@ -33,7 +33,7 @@ properties:
> >> patternProperties:
> >> '^pcie@[0-2],0$':
> >> type: object
> >> - $ref: /schemas/pci/pci-bus.yaml#
> >> + $ref: /schemas/pci/pci-host-bridge.yaml#
> >
> > I think this one should be pci-pci-bridge.yaml instead since it says
> > these are root ports and based on the unit-address here.
>
> I was thinking about this as well, but pci-pci-bridge.yaml defines
> compatible which is not present here at all. Since you suggest pci-pci,
> I'll go with this and make it a separate patch for easier review.
This was my concern at first. It does define compatible, but it
doesn't require it. So I think we are fine.
Rob
next prev parent reply other threads:[~2024-04-10 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 10:19 [PATCH 1/3] dt-bindings: PCI: cdns,cdns-pcie-host: drop redundant msi-parent and pci-bus.yaml Krzysztof Kozlowski
2024-04-07 10:19 ` [PATCH 2/3] dt-bindings: PCI: mediatek,mt7621: add missing child node reg Krzysztof Kozlowski
2024-04-07 12:36 ` Sergio Paracuellos
2024-04-10 17:48 ` Rob Herring
2024-04-07 10:20 ` [PATCH 3/3] dt-bindings: PCI: host-bridges: switch from deprecated pci-bus.yaml Krzysztof Kozlowski
2024-04-07 12:38 ` Sergio Paracuellos
2024-04-08 8:27 ` Geert Uytterhoeven
2024-04-10 17:48 ` Rob Herring
2024-04-10 18:00 ` Krzysztof Kozlowski
2024-04-10 18:11 ` Rob Herring [this message]
2024-04-10 17:55 ` Rob Herring
2024-04-10 17:58 ` Krzysztof Kozlowski
2024-04-10 17:35 ` [PATCH 1/3] dt-bindings: PCI: cdns,cdns-pcie-host: drop redundant msi-parent and pci-bus.yaml Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJM-DQvZ0fyJ17nY=vqtCRxyQwXGh6sbbAJ7rFjnAGrEA@mail.gmail.com' \
--to=robh@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asahi@lists.linux.dev \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=geert+renesas@glider.be \
--cc=gustavo.pimentel@synopsys.com \
--cc=heiko@sntech.de \
--cc=jianjun.wang@mediatek.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jim2101024@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kettenis@openbsd.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=magnus.damm@gmail.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marcan@marcan.st \
--cc=marek.vasut+renesas@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=nsaenz@kernel.org \
--cc=rjui@broadcom.com \
--cc=ryder.lee@mediatek.com \
--cc=sbranden@broadcom.com \
--cc=sergio.paracuellos@gmail.com \
--cc=shawn.lin@rock-chips.com \
--cc=srikanth.thokala@intel.com \
--cc=sven@svenpeter.dev \
--cc=thippeswamy.havalige@amd.com \
--cc=tjoseph@cadence.com \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
--cc=will@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).