From: Geert Uytterhoeven <geert@linux-m68k.org>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Andrew Lunn" <andrew@lunn.ch>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, netdev <netdev@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [net-next,v5] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN
Date: Mon, 13 May 2024 11:39:54 +0200 [thread overview]
Message-ID: <CAMuHMdWY-Ewm_ke6LxF1cpqQEdL3AnumyNKcTWvpFBJW_8wXJA@mail.gmail.com> (raw)
In-Reply-To: <20240509210903.3738334-1-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas, Andrew,
On Thu, May 9, 2024 at 11:10 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Add initial support for Renesas Ethernet-TSN End-station device of R-Car
> V4H. The Ethernet End-station can connect to an Ethernet network using a
> 10 Mbps, 100 Mbps, or 1 Gbps full-duplex link via MII/GMII/RMII/RGMII.
> Depending on the connected PHY.
>
> The driver supports Rx checksum and offload and hardware timestamps.
>
> While full power management and suspend/resume is not yet supported the
> driver enables runtime PM in order to enable the module clock. While
> explicit clock management using clk_enable() would suffice for the
> supported SoC, the module could be reused on SoCs where the module is
> part of a power domain.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> * Changes since v4
> - Enable GPOUT_RDM and GPOUT_TDM delays depending on phy-mode.
Thanks for the update!
> +static void rtsn_set_delay_mode(struct rtsn_private *priv)
> +{
> + u32 val = 0;
> +
> + /* The MAC is capable of applying a delay on both Rx and Tx. Each
> + * delay can either be on or off, there is no way to set its length.
> + *
> + * The exact delay applied depends on electric characteristics of the
> + * board. The datasheet describes a typical Rx delay of 1800 ps and a
> + * typical Tx delay of 2000 ps.
> + *
> + * There are boards where the RTSN device is used together with PHYs
> + * who do not support a large enough internal delays to function. These
> + * boards depends on the MAC applying these inexact delays.
> + */
> +
> + /* If the phy-mode is rgmii or rgmii-rxid apply Rx delay on the MAC */
> + if (priv->iface == PHY_INTERFACE_MODE_RGMII_ID ||
> + priv->iface == PHY_INTERFACE_MODE_RGMII_RXID)
> + val |= GPOUT_RDM;
> +
> + /* If the phy-mode is rgmii or rgmii-txid apply Tx delay on the MAC */
> + if (priv->iface == PHY_INTERFACE_MODE_RGMII_ID ||
> + priv->iface == PHY_INTERFACE_MODE_RGMII_TXID)
> + val |= GPOUT_TDM;
> +
> + rtsn_write(priv, GPOUT, val);
> +}
> +static int rtsn_phy_init(struct rtsn_private *priv)
> +{
> + struct device_node *np = priv->ndev->dev.parent->of_node;
> + struct phy_device *phydev;
> + struct device_node *phy;
> + phy_interface_t iface;
> +
> + /* Delays, if any, are applied by the MAC. Mask RGMII mode passed to the
> + * PHY to avoid it also adding the delay.
> + */
> + switch (priv->iface) {
> + case PHY_INTERFACE_MODE_RGMII:
> + case PHY_INTERFACE_MODE_RGMII_ID:
> + case PHY_INTERFACE_MODE_RGMII_RXID:
> + case PHY_INTERFACE_MODE_RGMII_TXID:
> + iface = PHY_INTERFACE_MODE_RGMII;
> + break;
> + default:
> + iface = priv->iface;
> + break;
> + }
This introduces the same issues (the "workaround" state below) we had
with ravb before.
9b23203c32ee02cd ("ravb: Mask PHY mode to avoid inserting delays twice")
was the workaround,
a6f51f2efa742df0 ("ravb: Add support for explicit internal clock delay
configuration")
was the final fix.
Do we really want to repeat that mistake?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2024-05-13 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 21:09 [net-next,v5] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN Niklas Söderlund
2024-05-13 9:39 ` Geert Uytterhoeven [this message]
2024-05-13 10:09 ` Niklas Söderlund
2024-05-13 11:44 ` Geert Uytterhoeven
2024-05-13 12:56 ` Niklas Söderlund
2024-05-14 12:25 ` Geert Uytterhoeven
2024-05-13 13:38 ` Andrew Lunn
2024-05-14 0:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWY-Ewm_ke6LxF1cpqQEdL3AnumyNKcTWvpFBJW_8wXJA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).