From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: linus.walleij@linaro.org, tglx@linutronix.de,
biju.das.jz@bp.renesas.com, linux-renesas-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v3 2/2] pinctrl: renesas: rzg2l: Configure the interrupt type on resume
Date: Thu, 18 Apr 2024 16:07:14 +0200 [thread overview]
Message-ID: <CAMuHMdXescaJ-V0iuXsxo=X-7RYTBR1W5+EXZCw_2VPHEFGzdA@mail.gmail.com> (raw)
In-Reply-To: <20240320104230.446400-3-claudiu.beznea.uj@bp.renesas.com>
Hi Claudiu,
On Wed, Mar 20, 2024 at 11:43 AM Claudiu <claudiu.beznea@tuxon.dev> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Commit dce0919c83c3 ("irqchip/renesas-rzg2l: Do not set TIEN and TINT
> source at the same time") removed the setup of TINT from
> rzg2l_irqc_irq_enable(). To address the spourious interrupt issue the setup
> of TINT has been moved in rzg2l_tint_set_edge() though
> rzg2l_disable_tint_and_set_tint_source(). With this, the interrupts are
> not properly re-configured after a suspend-to-RAM cycle. To address
> this issue and avoid spurious interrupts while resumming set the
> interrupt type before enabling it.
>
> Fixes: dce0919c83c3 ("irqchip/renesas-rzg2l: Do not set TIEN and TINT source at the same time")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Thanks for your patch!
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -2045,7 +2045,9 @@ static void rzg2l_gpio_irq_restore(struct rzg2l_pinctrl *pctrl)
>
> for (unsigned int i = 0; i < RZG2L_TINT_MAX_INTERRUPT; i++) {
> struct irq_data *data;
> + unsigned long flags;
> unsigned int virq;
> + int ret;
>
> if (!pctrl->hwirq[i])
> continue;
> @@ -2063,17 +2065,17 @@ static void rzg2l_gpio_irq_restore(struct rzg2l_pinctrl *pctrl)
> continue;
> }
>
> - if (!irqd_irq_disabled(data)) {
> - unsigned long flags;
> -
> - /*
> - * This has to be atomically executed to protect against a concurrent
> - * interrupt.
> - */
> - raw_spin_lock_irqsave(&pctrl->lock.rlock, flags);
> + /*
> + * This has to be atomically executed to protect against a concurrent
> + * interrupt.
> + */
> + raw_spin_lock_irqsave(&pctrl->lock.rlock, flags);
> + ret = rzg2l_gpio_irq_set_type(data, irqd_get_trigger_type(data));
> + if (ret)
> + dev_crit(pctrl->dev, "Failed to set IRQ type for virq=%u\n", virq);
> + else if (!irqd_irq_disabled(data))
> rzg2l_gpio_irq_enable(data);
> - raw_spin_unlock_irqrestore(&pctrl->lock.rlock, flags);
> - }
> + raw_spin_unlock_irqrestore(&pctrl->lock.rlock, flags);
> }
> }
LGTM, but I'd rather move the dev_crit() outside (i.e. after) the
critical section.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2024-04-18 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 10:42 [PATCH v3 0/2] pinctrl: renesas: rzg2l: fixes for pinctrl driver Claudiu
2024-03-20 10:42 ` [PATCH v3 1/2] pinctrl: renesas: rzg2l: Execute atomically the interrupt configuration Claudiu
2024-03-20 10:42 ` [PATCH v3 2/2] pinctrl: renesas: rzg2l: Configure the interrupt type on resume Claudiu
2024-03-20 11:08 ` Biju Das
2024-03-20 11:28 ` claudiu beznea
2024-03-20 11:39 ` Biju Das
2024-04-18 14:07 ` Geert Uytterhoeven [this message]
2024-04-19 5:48 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdXescaJ-V0iuXsxo=X-7RYTBR1W5+EXZCw_2VPHEFGzdA@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).