Linux-Renesas-SoC Archive mirror
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>
Cc: "linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] arm64: dts: renesas: r8a779h0: Add INTC-EX node
Date: Wed, 17 Apr 2024 07:39:49 +0000	[thread overview]
Message-ID: <TYWPR01MB110305DA3F6ADF7C2EB415212D80F2@TYWPR01MB11030.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <66aba473186df9a137e7f95393209b23a5916fd1.1713281889.git.geert+renesas@glider.be>

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Wednesday, April 17, 2024 12:40 AM
> 
> Add the device node for the Interrupt Controller for External Devices
> (INTC-EX) on the Renesas R-Car V4M (R8A779H0) SoC, which serves external
> IRQ pins IRQ[0-5].
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

> ---
> IRQ2 was tested on the Gray Hawk Single development board using
> gpio-keys.  With the default hardware setup, this causes an interrupt
> storm, as expected (pin is shared with MD0).

I tested on the Gray Hawk Single board, and it worked correctly like below:
- If SW5-1 on the SW board turned on, the interrupt happened (as strom).
- After that, if the SW5-1 turned off, the interrupt stopped and /proc/interrupts
  showed the interrupt counts.

So,
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> To be queued in renesas-devel for v6.10.
> ---
>  arch/arm64/boot/dts/renesas/r8a779h0.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
> index 530219f21295f76f..bd3955316a88c8f2 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
> @@ -404,6 +404,22 @@ tsc: thermal@e6198000 {
>  			#thermal-sensor-cells = <1>;
>  		};
> 
> +		intc_ex: interrupt-controller@e61c0000 {
> +			compatible = "renesas,intc-ex-r8a779h0", "renesas,irqc";
> +			#interrupt-cells = <2>;
> +			interrupt-controller;
> +			reg = <0 0xe61c0000 0 0x200>;
> +			interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 611>;
> +			power-domains = <&sysc R8A779H0_PD_ALWAYS_ON>;
> +			resets = <&cpg 611>;
> +		};
> +
>  		tmu0: timer@e61e0000 {
>  			compatible = "renesas,tmu-r8a779h0", "renesas,tmu";
>  			reg = <0 0xe61e0000 0 0x30>;
> --
> 2.34.1
> 


      reply	other threads:[~2024-04-17  7:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 15:40 [PATCH] arm64: dts: renesas: r8a779h0: Add INTC-EX node Geert Uytterhoeven
2024-04-17  7:39 ` Yoshihiro Shimoda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYWPR01MB110305DA3F6ADF7C2EB415212D80F2@TYWPR01MB11030.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).