From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Anup Patel <anup.patel@wdc.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 2/2] dt-bindings: timer: sifive, clint: Group interrupt tuples
Date: Tue, 21 Dec 2021 10:56:32 -0400 [thread overview]
Message-ID: <YcHrIM9e+tSmpk8B@robh.at.kernel.org> (raw)
In-Reply-To: <b2409de8943b56dfda2c972f4fe566a381be07a7.1639744468.git.geert@linux-m68k.org>
On Fri, Dec 17, 2021 at 01:38:04PM +0100, Geert Uytterhoeven wrote:
> To improve human readability and enable automatic validation, the tuples
> in "interrupts-extended" properties should be grouped using angle
> brackets.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> v3:
> - Add Reviewed-by,
Did you? ;)
Reviewed-by: Rob Herring <robh@kernel.org>
>
> v2:
> - Split in two patches.
> ---
> Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> index b75fd6f982b1ecb3..3b25ec37d81159cb 100644
> --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml
> @@ -57,10 +57,10 @@ examples:
> - |
> timer@2000000 {
> compatible = "sifive,fu540-c000-clint", "sifive,clint0";
> - interrupts-extended = <&cpu1intc 3 &cpu1intc 7
> - &cpu2intc 3 &cpu2intc 7
> - &cpu3intc 3 &cpu3intc 7
> - &cpu4intc 3 &cpu4intc 7>;
> + interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>,
> + <&cpu2intc 3>, <&cpu2intc 7>,
> + <&cpu3intc 3>, <&cpu3intc 7>,
> + <&cpu4intc 3>, <&cpu4intc 7>;
> reg = <0x2000000 0x10000>;
> };
> ...
> --
> 2.25.1
>
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2021-12-21 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 12:38 [PATCH v3 0/2] dt-bindings: timer: sifive, clint: Miscellaneous improvements Geert Uytterhoeven
2021-12-17 12:38 ` [PATCH v3 1/2] dt-bindings: timer: sifive, clint: Fix number of interrupts Geert Uytterhoeven
2021-12-17 12:48 ` Anup Patel
2022-01-26 19:36 ` Rob Herring
2022-01-26 20:06 ` Geert Uytterhoeven
2021-12-17 12:38 ` [PATCH v3 2/2] dt-bindings: timer: sifive, clint: Group interrupt tuples Geert Uytterhoeven
2021-12-21 14:56 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcHrIM9e+tSmpk8B@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=anup.patel@wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).