From: Mike Rapoport <rppt@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: "Alexandre Ghiti" <alexghiti@rivosinc.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Björn Töpel" <bjorn@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"David S. Miller" <davem@davemloft.net>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Donald Dutile" <ddutile@redhat.com>,
"Eric Chanudet" <echanude@redhat.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Helge Deller" <deller@gmx.de>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Kent Overstreet" <kent.overstreet@linux.dev>,
"Liviu Dudau" <liviu@dudau.co.uk>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nadav Amit" <nadav.amit@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Rick Edgecombe" <rick.p.edgecombe@intel.com>,
"Russell King" <linux@armlinux.org.uk>,
"Sam Ravnborg" <sam@ravnborg.org>, "Song Liu" <song@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Will Deacon" <will@kernel.org>,
bpf@vger.kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-mm@kvack.org, linux-modules@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev,
netdev@vger.kernel.org, sparclinux@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH v8 00/17] mm: jit/text allocator
Date: Sun, 5 May 2024 19:21:55 +0300 [thread overview]
Message-ID: <ZjeyI8xbNTrAWn9m@kernel.org> (raw)
In-Reply-To: <20240505142600.2322517-1-rppt@kernel.org>
This is embarrassing, but these patches were from a wrong branch :(
Please ignore.
On Sun, May 05, 2024 at 05:25:43PM +0300, Mike Rapoport wrote:
> From: "Mike Rapoport (IBM)" <rppt@kernel.org>
>
> Hi,
>
> The patches are also available in git:
> https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=execmem/v8
>
> v8:
> * fix intialization of default_execmem_info
>
> v7: https://lore.kernel.org/all/20240429121620.1186447-1-rppt@kernel.org
> * define MODULE_{VADDR,END} for riscv32 to fix the build and avoid
> #ifdefs in a function body
> * add Acks, thanks everybody
>
> v6: https://lore.kernel.org/all/20240426082854.7355-1-rppt@kernel.org
> * restore patch "arm64: extend execmem_info for generated code
> allocations" that disappeared in v5 rebase
> * update execmem initialization so that by default it will be
> initialized early while late initialization will be an opt-in
>
> v5: https://lore.kernel.org/all/20240422094436.3625171-1-rppt@kernel.org
> * rebase on v6.9-rc4 to avoid a conflict in kprobes
> * add copyrights to mm/execmem.c (Luis)
> * fix spelling (Ingo)
> * define MODULES_VADDDR for sparc (Sam)
> * consistently initialize struct execmem_info (Peter)
> * reduce #ifdefs in function bodies in kprobes (Masami)
>
> v4: https://lore.kernel.org/all/20240411160051.2093261-1-rppt@kernel.org
> * rebase on v6.9-rc2
> * rename execmem_params to execmem_info and execmem_arch_params() to
> execmem_arch_setup()
> * use single execmem_alloc() API instead of execmem_{text,data}_alloc() (Song)
> * avoid extra copy of execmem parameters (Rick)
> * run execmem_init() as core_initcall() except for the architectures that
> may allocated text really early (currently only x86) (Will)
> * add acks for some of arm64 and riscv changes, thanks Will and Alexandre
> * new commits:
> - drop call to kasan_alloc_module_shadow() on arm64 because it's not
> needed anymore
> - rename MODULE_START to MODULES_VADDR on MIPS
> - use CONFIG_EXECMEM instead of CONFIG_MODULES on powerpc as per Christophe:
> https://lore.kernel.org/all/79062fa3-3402-47b3-8920-9231ad05e964@csgroup.eu/
>
> v3: https://lore.kernel.org/all/20230918072955.2507221-1-rppt@kernel.org
> * add type parameter to execmem allocation APIs
> * remove BPF dependency on modules
>
> v2: https://lore.kernel.org/all/20230616085038.4121892-1-rppt@kernel.org
> * Separate "module" and "others" allocations with execmem_text_alloc()
> and jit_text_alloc()
> * Drop ROX entailment on x86
> * Add ack for nios2 changes, thanks Dinh Nguyen
>
> v1: https://lore.kernel.org/all/20230601101257.530867-1-rppt@kernel.org
>
> = Cover letter from v1 (sligtly updated) =
>
> module_alloc() is used everywhere as a mean to allocate memory for code.
>
> Beside being semantically wrong, this unnecessarily ties all subsystmes
> that need to allocate code, such as ftrace, kprobes and BPF to modules and
> puts the burden of code allocation to the modules code.
>
> Several architectures override module_alloc() because of various
> constraints where the executable memory can be located and this causes
> additional obstacles for improvements of code allocation.
>
> A centralized infrastructure for code allocation allows allocations of
> executable memory as ROX, and future optimizations such as caching large
> pages for better iTLB performance and providing sub-page allocations for
> users that only need small jit code snippets.
>
> Rick Edgecombe proposed perm_alloc extension to vmalloc [1] and Song Liu
> proposed execmem_alloc [2], but both these approaches were targeting BPF
> allocations and lacked the ground work to abstract executable allocations
> and split them from the modules core.
>
> Thomas Gleixner suggested to express module allocation restrictions and
> requirements as struct mod_alloc_type_params [3] that would define ranges,
> protections and other parameters for different types of allocations used by
> modules and following that suggestion Song separated allocations of
> different types in modules (commit ac3b43283923 ("module: replace
> module_layout with module_memory")) and posted "Type aware module
> allocator" set [4].
>
> I liked the idea of parametrising code allocation requirements as a
> structure, but I believe the original proposal and Song's module allocator
> was too module centric, so I came up with these patches.
>
> This set splits code allocation from modules by introducing execmem_alloc()
> and and execmem_free(), APIs, replaces call sites of module_alloc() and
> module_memfree() with the new APIs and implements core text and related
> allocations in a central place.
>
> Instead of architecture specific overrides for module_alloc(), the
> architectures that require non-default behaviour for text allocation must
> fill execmem_info structure and implement execmem_arch_setup() that returns
> a pointer to that structure. If an architecture does not implement
> execmem_arch_setup(), the defaults compatible with the current
> modules::module_alloc() are used.
>
> Since architectures define different restrictions on placement,
> permissions, alignment and other parameters for memory that can be used by
> different subsystems that allocate executable memory, execmem APIs
> take a type argument, that will be used to identify the calling subsystem
> and to allow architectures to define parameters for ranges suitable for that
> subsystem.
>
> The new infrastructure allows decoupling of BPF, kprobes and ftrace from
> modules, and most importantly it paves the way for ROX allocations for
> executable memory.
>
> [1] https://lore.kernel.org/lkml/20201120202426.18009-1-rick.p.edgecombe@intel.com/
> [2] https://lore.kernel.org/all/20221107223921.3451913-1-song@kernel.org/
> [3] https://lore.kernel.org/all/87v8mndy3y.ffs@tglx/
> [4] https://lore.kernel.org/all/20230526051529.3387103-1-song@kernel.org
>
>
> Mike Rapoport (IBM) (17):
> arm64: module: remove unneeded call to kasan_alloc_module_shadow()
> mips: module: rename MODULE_START to MODULES_VADDR
> nios2: define virtual address space for modules
> sparc: simplify module_alloc()
> module: make module_memory_{alloc,free} more self-contained
> mm: introduce execmem_alloc() and execmem_free()
> mm/execmem, arch: convert simple overrides of module_alloc to execmem
> mm/execmem, arch: convert remaining overrides of module_alloc to
> execmem
> riscv: extend execmem_params for generated code allocations
> arm64: extend execmem_info for generated code allocations
> powerpc: extend execmem_params for kprobes allocations
> arch: make execmem setup available regardless of CONFIG_MODULES
> x86/ftrace: enable dynamic ftrace without CONFIG_MODULES
> powerpc: use CONFIG_EXECMEM instead of CONFIG_MODULES where
> appropriate
> kprobes: remove dependency on CONFIG_MODULES
> bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of
> fixup: convert remaining archs: defaults handling
>
> arch/Kconfig | 10 +-
> arch/arm/kernel/module.c | 34 -------
> arch/arm/mm/init.c | 45 +++++++++
> arch/arm64/Kconfig | 1 +
> arch/arm64/kernel/module.c | 126 -----------------------
> arch/arm64/kernel/probes/kprobes.c | 7 --
> arch/arm64/mm/init.c | 140 ++++++++++++++++++++++++++
> arch/arm64/net/bpf_jit_comp.c | 11 ---
> arch/loongarch/kernel/module.c | 6 --
> arch/loongarch/mm/init.c | 21 ++++
> arch/mips/include/asm/pgtable-64.h | 4 +-
> arch/mips/kernel/module.c | 10 --
> arch/mips/mm/fault.c | 4 +-
> arch/mips/mm/init.c | 23 +++++
> arch/nios2/include/asm/pgtable.h | 5 +-
> arch/nios2/kernel/module.c | 20 ----
> arch/nios2/mm/init.c | 21 ++++
> arch/parisc/kernel/module.c | 12 ---
> arch/parisc/mm/init.c | 23 ++++-
> arch/powerpc/Kconfig | 2 +-
> arch/powerpc/include/asm/kasan.h | 2 +-
> arch/powerpc/kernel/head_8xx.S | 4 +-
> arch/powerpc/kernel/head_book3s_32.S | 6 +-
> arch/powerpc/kernel/kprobes.c | 22 +----
> arch/powerpc/kernel/module.c | 38 -------
> arch/powerpc/lib/code-patching.c | 2 +-
> arch/powerpc/mm/book3s32/mmu.c | 2 +-
> arch/powerpc/mm/mem.c | 64 ++++++++++++
> arch/riscv/include/asm/pgtable.h | 3 +
> arch/riscv/kernel/module.c | 12 ---
> arch/riscv/kernel/probes/kprobes.c | 10 --
> arch/riscv/mm/init.c | 35 +++++++
> arch/riscv/net/bpf_jit_core.c | 13 ---
> arch/s390/kernel/ftrace.c | 4 +-
> arch/s390/kernel/kprobes.c | 4 +-
> arch/s390/kernel/module.c | 42 +-------
> arch/s390/mm/init.c | 30 ++++++
> arch/sparc/include/asm/pgtable_32.h | 2 +
> arch/sparc/kernel/module.c | 30 ------
> arch/sparc/mm/Makefile | 2 +
> arch/sparc/mm/execmem.c | 21 ++++
> arch/sparc/net/bpf_jit_comp_32.c | 8 +-
> arch/x86/Kconfig | 1 +
> arch/x86/kernel/ftrace.c | 16 +--
> arch/x86/kernel/kprobes/core.c | 4 +-
> arch/x86/kernel/module.c | 51 ----------
> arch/x86/mm/init.c | 29 ++++++
> include/linux/execmem.h | 132 +++++++++++++++++++++++++
> include/linux/module.h | 9 ++
> include/linux/moduleloader.h | 15 ---
> kernel/bpf/Kconfig | 2 +-
> kernel/bpf/core.c | 6 +-
> kernel/kprobes.c | 63 +++++++-----
> kernel/module/Kconfig | 1 +
> kernel/module/main.c | 105 +++++++++-----------
> kernel/trace/trace_kprobe.c | 20 +++-
> mm/Kconfig | 3 +
> mm/Makefile | 1 +
> mm/execmem.c | 143 +++++++++++++++++++++++++++
> mm/mm_init.c | 2 +
> 60 files changed, 903 insertions(+), 581 deletions(-)
> create mode 100644 arch/sparc/mm/execmem.c
> create mode 100644 include/linux/execmem.h
> create mode 100644 mm/execmem.c
>
>
> base-commit: 0bbac3facb5d6cc0171c45c9873a2dc96bea9680
> --
> 2.43.0
>
>
--
Sincerely yours,
Mike.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2024-05-05 16:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 14:25 [PATCH v8 00/17] mm: jit/text allocator Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 01/17] arm64: module: remove unneeded call to kasan_alloc_module_shadow() Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 02/17] mips: module: rename MODULE_START to MODULES_VADDR Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 03/17] nios2: define virtual address space for modules Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 04/17] sparc: simplify module_alloc() Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 05/17] module: make module_memory_{alloc,free} more self-contained Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 06/17] mm: introduce execmem_alloc() and execmem_free() Mike Rapoport
2024-05-06 18:15 ` Steven Rostedt
2024-05-05 14:25 ` [PATCH v8 07/17] mm/execmem, arch: convert simple overrides of module_alloc to execmem Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 08/17] mm/execmem, arch: convert remaining " Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 09/17] riscv: extend execmem_params for generated code allocations Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 10/17] arm64: extend execmem_info " Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 11/17] powerpc: extend execmem_params for kprobes allocations Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 12/17] arch: make execmem setup available regardless of CONFIG_MODULES Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 13/17] x86/ftrace: enable dynamic ftrace without CONFIG_MODULES Mike Rapoport
2024-05-06 18:22 ` Steven Rostedt
2024-05-05 14:25 ` [PATCH v8 14/17] powerpc: use CONFIG_EXECMEM instead of CONFIG_MODULES where appropriate Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 15/17] kprobes: remove dependency on CONFIG_MODULES Mike Rapoport
2024-05-05 14:25 ` [PATCH v8 16/17] bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of Mike Rapoport
2024-05-05 14:26 ` [PATCH v8 17/17] fixup: convert remaining archs: defaults handling Mike Rapoport
2024-05-05 16:21 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjeyI8xbNTrAWn9m@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexghiti@rivosinc.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=ddutile@redhat.com \
--cc=deller@gmx.de \
--cc=dinguyen@kernel.org \
--cc=echanude@redhat.com \
--cc=hca@linux.ibm.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liviu@dudau.co.uk \
--cc=loongarch@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nadav.amit@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=peterz@infradead.org \
--cc=philmd@linaro.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rostedt@goodmis.org \
--cc=sam@ravnborg.org \
--cc=song@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).