From: Mathias Krause <minipli@grsecurity.net>
To: Clark Williams <williams@redhat.com>, John Kacur <jkacur@redhat.com>
Cc: linux-rt-users@vger.kernel.org, Mathias Krause <minipli@grsecurity.net>
Subject: [PATCH] Revert "rt-tests: Makefile: ctags: Change obsolete extra to extras"
Date: Tue, 26 Sep 2023 13:04:09 +0200 [thread overview]
Message-ID: <20230926110409.1244298-1-minipli@grsecurity.net> (raw)
Commit 974241c78a6f ("rt-tests: Makefile: ctags: Change obsolete extra to
extras") not only broke the generation of tags files -- at least for exuberant
ctags version 5.9 as shipped in Debian -- but it also added -Wextra to CFLAGS,
leading to many warnings.
Simply revert the commit to undo the unintended change and unbreak ctags file
generation.
Signed-off-by: Mathias Krause <minipli@grsecurity.net>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 32a9f41198a4..3b9e90d528e5 100644
--- a/Makefile
+++ b/Makefile
@@ -30,7 +30,7 @@ prefix ?= /usr/local
bindir ?= $(prefix)/bin
mandir ?= $(prefix)/share/man
-CFLAGS ?= -Wall -Wno-nonnull -Wextra
+CFLAGS ?= -Wall -Wno-nonnull
CPPFLAGS += -D_GNU_SOURCE -Isrc/include
LDFLAGS ?=
@@ -253,4 +253,4 @@ help:
.PHONY: tags
tags:
- ctags -R --extras=+f --c-kinds=+p --exclude=tmp --exclude=BUILD *
+ ctags -R --extra=+f --c-kinds=+p --exclude=tmp --exclude=BUILD *
--
2.30.2
next reply other threads:[~2023-09-26 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 11:04 Mathias Krause [this message]
2023-10-18 6:29 ` [PATCH] Revert "rt-tests: Makefile: ctags: Change obsolete extra to extras" Mathias Krause
2023-10-18 14:03 ` John Kacur
2023-10-19 6:49 ` Mathias Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926110409.1244298-1-minipli@grsecurity.net \
--to=minipli@grsecurity.net \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).