From: John Kacur <jkacur@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: linux-rt-users@vger.kernel.org, "Newman, Chuck" <chuck.newman@hpe.com>
Subject: Re: [PATCH] rt-tests: oslat should use MHz, not Mhz
Date: Fri, 2 Feb 2024 11:33:38 -0500 (EST) [thread overview]
Message-ID: <5abaff95-34f1-bfd1-316f-24f07cd73d9c@redhat.com> (raw)
In-Reply-To: <ZbvBUmLef6FabeUa@tpad>
On Thu, 1 Feb 2024, Marcelo Tosatti wrote:
>
> Usage of Mhz, in oslat, is incorrect:
>
> From https://www.nist.gov/pml/owm/writing-si-metric-system-units#:~:text=NOT%20250%20mms.-,Capitalization,the%20beginning%20of%20the%20sentence:
>
> "When the unit is derived from the name of a person, the symbol or the first letter of the symbol is an uppercase letter (W for the unit "watt" or Pa for the unit "pascal")."
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> Reported-by: Chuck Newman <chuck.newman@hpe.com>
>
> diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
> index 4bdca64..e398f20 100644
> --- a/src/oslat/oslat.c
> +++ b/src/oslat/oslat.c
> @@ -501,7 +501,7 @@ static void write_summary(struct thread *t)
> calculate(t);
>
> putfield("Core", t[i].core_i, "d", "");
> - putfield("Counter Freq", t[i].counter_mhz, "u", " (Mhz)");
> + putfield("Counter Freq", t[i].counter_mhz, "u", " (MHz)");
>
> for (j = 0; j < g.bucket_size; j++) {
> if (j < g.bucket_size-1 && g.output_omit_zero_buckets) {
>
>
>
Signed-off-by: John Kacur <jkacur@redhat.com>
prev parent reply other threads:[~2024-02-02 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 16:05 [PATCH] rt-tests: oslat should use MHz, not Mhz Marcelo Tosatti
2024-02-02 16:33 ` John Kacur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5abaff95-34f1-bfd1-316f-24f07cd73d9c@redhat.com \
--to=jkacur@redhat.com \
--cc=chuck.newman@hpe.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).