From: John Ogness <john.ogness@linutronix.de>
To: Esben Haabendal <esben@geanix.com>
Cc: "Petr Mladek" <pmladek@suse.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
linux-rt-users@vger.kernel.org,
"Martin Hundebøll" <martin@geanix.com>
Subject: Re: [PATCH 1/2] printk: export pr_flush()
Date: Wed, 03 Apr 2024 12:15:04 +0206 [thread overview]
Message-ID: <87o7aqyczj.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <87v84yye24.fsf@geanix.com>
On 2024-04-03, Esben Haabendal <esben@geanix.com> wrote:
>> Finally, if someone wanted to try porting another driver for PREEMPT_RT
>> (for example, the imx serial console), I would certainly be interested
>> in reviewing and integrating the patches for the PREEMPT_RT tree.
>
> Sounds good. I have looked at porting imx uart driver to nbcon, and have
> something working now. It does smell quite a lot of copy-paste
> behaviour, but I will send it as an RFC for you to see when I have
> tested it a bit more.
Great!
> The write_thread and write_atomic functions share quite a lot of code,
> carrying half of the copy-paste smell.
> The other half is the inner loop of the write_thread function, which is
> almost identical in 8250 and imx drivers.
>
> I guess there is room to refactor this to avoid this amount of
> copy-paste before starting mass-porting.
I certainly hope so. So far my 8250 work has been making sure it is
technically reliable. I expect there can be a lot of improvement to make
it more efficient and generic.
John
prev parent reply other threads:[~2024-04-03 10:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 10:10 [PATCH 1/2] printk: export pr_flush() Esben Haabendal
2024-04-02 10:10 ` [PATCH 2/2] reboot: flush printk buffers before final shutdown Esben Haabendal
2024-04-02 10:12 ` Esben Haabendal
2024-04-02 10:13 ` Esben Haabendal
2024-04-02 10:12 ` [PATCH 1/2] printk: export pr_flush() Esben Haabendal
2024-04-02 10:13 ` Esben Haabendal
2024-04-02 10:25 ` John Ogness
2024-04-02 11:19 ` Esben Haabendal
2024-04-02 13:23 ` John Ogness
2024-04-02 14:41 ` Esben Haabendal
2024-04-02 15:20 ` John Ogness
2024-04-03 9:45 ` Esben Haabendal
2024-04-03 10:09 ` John Ogness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7aqyczj.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=esben@geanix.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=martin@geanix.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).