From: Clark Williams <williams@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Daniel Wagner <daniel.wagner@suse.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Pavel Machek <pavel@denx.de>,
Joseph Salisbury <joseph.salisbury@canonical.com>
Subject: Re: [ANNOUNCE] 6.6.12-rt20
Date: Wed, 31 Jan 2024 22:05:26 +0000 [thread overview]
Message-ID: <CAMLffL9fVw4M7b4cnQdy7KwHJGQNyiM6SvR-3zHkGKrkzV3mEw@mail.gmail.com> (raw)
In-Reply-To: <CAMLffL8qyNCocBGtxfDO49dORs_QFdv-6ZrvBEbhxjoBBk4rrw@mail.gmail.com>
To be clear, I'll drop the referenced hunk from the RISC-V commit and
revert c15abad8f7159
On Wed, Jan 31, 2024 at 10:04 PM Clark Williams <williams@redhat.com> wrote:
>
> I'll revert that commit and re-release the 6.6.14 I just pushed
>
> On Wed, Jan 24, 2024 at 9:48 AM Sebastian Andrzej Siewior
> <bigeasy@linutronix.de> wrote:
> >
> > On 2024-01-18 20:59:45 [-0000], Clark Williams wrote:
> > > Hello RT-list!
> > Hi Clark,
> >
> > > I'm pleased to announce the 6.6.12-rt20 stable release.
> >
> > I've been looking over it and it looks okay. Then I compared how it
> > would do it vs your outcome and noticed this:
> >
> > --- a/arch/riscv/kernel/cpufeature.c
> > +++ b/arch/riscv/kernel/cpufeature.c
> > @@ -575,12 +575,6 @@ static int check_unaligned_access(void *param)
> > if (per_cpu(misaligned_access_speed, cpu) != RISCV_HWPROBE_MISALIGNED_UNKNOWN)
> > return;
> >
> > - page = alloc_pages(GFP_NOWAIT, get_order(MISALIGNED_BUFFER_SIZE));
> > - if (!page) {
> > - pr_warn("Can't alloc pages to measure memcpy performance");
> > - return;
> > - }
> > -
> > /* Make an unaligned destination buffer. */
> > dst = (void *)((unsigned long)page_address(page) | 0x1);
> > /* Unalign src as well, but differently (off by 1 + 2 = 3). */
> >
> > You shouldn't allocate that page. Nobody will free it, that page is
> > passed via an argument now. Please drop hunk.
> >
> > While at it, do you think you can drop patch
> > preempt-Put-preempt_enable-within-an-instrumentation.patch
> >
> > or revert commit
> > c15abad8f7159 ("preempt: Put preempt_enable() within an instrumentation*() section.")
> >
> > I've been looking over it and it is fixed as of v6.6 so this patch is no
> > longer needed.
> >
> > > Enjoy!
> > > Clark
> >
> > Sebastian
> >
prev parent reply other threads:[~2024-01-31 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 20:59 [ANNOUNCE] 6.6.12-rt20 Clark Williams
2024-01-24 9:48 ` Sebastian Andrzej Siewior
2024-01-31 22:04 ` Clark Williams
2024-01-31 22:05 ` Clark Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMLffL9fVw4M7b4cnQdy7KwHJGQNyiM6SvR-3zHkGKrkzV3mEw@mail.gmail.com \
--to=williams@redhat.com \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=daniel.wagner@suse.com \
--cc=jkacur@redhat.com \
--cc=joseph.salisbury@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=pavel@denx.de \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).