From: Wen Gu <guwen@linux.alibaba.com>
To: Jan Karcher <jaka@linux.ibm.com>,
wintera@linux.ibm.com, twinkler@linux.ibm.com, hca@linux.ibm.com,
gor@linux.ibm.com, agordeev@linux.ibm.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
wenjia@linux.ibm.com
Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com,
alibuda@linux.alibaba.com, tonylu@linux.alibaba.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH net-next v4 04/11] net/smc: implement some unsupported operations of loopback-ism
Date: Fri, 22 Mar 2024 09:39:41 +0800 [thread overview]
Message-ID: <d42c7545-4ff4-4337-9489-d9d757eee007@linux.alibaba.com> (raw)
In-Reply-To: <f9bfbc0f-7cfc-47c0-b06c-23ee3e70a420@linux.ibm.com>
On 2024/3/21 16:12, Jan Karcher wrote:
>
>
> On 17/03/2024 11:05, Wen Gu wrote:
>> vlan operations are not supported currently since the need for vlan in
>> loopback-ism situation does not seem to be strong.
>>
>> signal_event operation is not supported since no event now needs to be
>> processed by loopback-ism device.
>
> Hi Wen Gu,
>
> Could we re-phrase this commit message please? I had some trouble reading it. Maybe something along:
>
> Operations that loopback-ism does not support currently:
> - vlan operations, since there is no strong use-case for it
> - signal_event operations, since there are no events to be processed
> by the loopback-ism device.
>
> Thanks
> - Jan
>
>>
>> Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
OK, it will be improved as you suggested. Thanks!
next prev parent reply other threads:[~2024-03-22 1:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 10:05 [RFC PATCH net-next v4 00/11] net/smc: SMC intra-OS shortcut with loopback-ism Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 01/11] net/smc: decouple ism_client from SMC-D DMB registration Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 02/11] net/smc: introduce loopback-ism for SMC intra-OS shortcut Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 03/11] net/smc: implement ID-related operations of loopback-ism Wen Gu
2024-03-21 8:12 ` Jan Karcher
2024-03-22 1:37 ` Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 04/11] net/smc: implement some unsupported " Wen Gu
2024-03-21 8:12 ` Jan Karcher
2024-03-22 1:39 ` Wen Gu [this message]
2024-03-17 10:05 ` [RFC PATCH net-next v4 05/11] net/smc: implement DMB-related " Wen Gu
2024-03-21 8:12 ` Jan Karcher
2024-03-22 12:30 ` Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 06/11] net/smc: ignore loopback-ism when dumping SMC-D devices Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 07/11] net/smc: register loopback-ism into SMC-D device list Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 08/11] net/smc: add operations to merge sndbuf with peer DMB Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 09/11] net/smc: attach or detach ghost sndbuf to " Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 10/11] net/smc: adapt cursor update when sndbuf and peer DMB are merged Wen Gu
2024-03-21 8:12 ` Jan Karcher
2024-03-22 1:49 ` Wen Gu
2024-03-17 10:05 ` [RFC PATCH net-next v4 11/11] net/smc: implement DMB-merged operations of loopback-ism Wen Gu
2024-03-21 8:11 ` [RFC PATCH net-next v4 00/11] net/smc: SMC intra-OS shortcut with loopback-ism Jan Karcher
2024-03-22 12:36 ` Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d42c7545-4ff4-4337-9489-d9d757eee007@linux.alibaba.com \
--to=guwen@linux.alibaba.com \
--cc=agordeev@linux.ibm.com \
--cc=alibuda@linux.alibaba.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jaka@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=svens@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=twinkler@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).