From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-safety@lists.elisa.tech,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH] proc: remove a pointless assignment
Date: Wed, 30 Sep 2020 19:53:59 +0100 [thread overview]
Message-ID: <20200930185359.27526-1-sudipm.mukherjee@gmail.com> (raw)
The variable 'env_start' has only been used for the if condition before
this assignment and is never read after this.
So, remove the assignement.
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
fs/proc/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index aa69c35d904c..238925ff3a80 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -279,7 +279,7 @@ static ssize_t get_mm_cmdline(struct mm_struct *mm, char __user *buf,
* only when it overflows into the environment area.
*/
if (env_start != arg_end || env_end < env_start)
- env_start = env_end = arg_end;
+ env_end = arg_end;
len = env_end - arg_start;
/* We're not going to care if "*ppos" has high bits set */
--
2.11.0
reply other threads:[~2020-09-30 18:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930185359.27526-1-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).