From: Kees Cook <keescook@chromium.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Iurii Zaikin <yzaikin@google.com>,
linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] kernel/sysctl.c: drop unneeded assignment in proc_do_large_bitmap()
Date: Mon, 5 Oct 2020 14:05:11 -0700 [thread overview]
Message-ID: <202010051404.CEE37CD617@keescook> (raw)
In-Reply-To: <20201005203749.28083-1-sudipm.mukherjee@gmail.com>
On Mon, Oct 05, 2020 at 09:37:49PM +0100, Sudip Mukherjee wrote:
> The variable 'first' is assigned 0 inside the while loop in the if block
> but it is not used in the if block and is only used in the else block.
> So, remove the unneeded assignment.
True, but in this case, please move the definition of "first" into the
else block so it in only in scope there.
Thanks!
-Kees
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
>
> The resultant binary stayed same after this change. Verified with
> md5sum which remained same with and without this change.
>
> $ md5sum kernel/sysctl.o
> e9e97adbfd3f0b32f83dd35d100c0e4e kernel/sysctl.o
>
> kernel/sysctl.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index ce75c67572b9..b51ebfd1ba6e 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -1508,7 +1508,6 @@ int proc_do_large_bitmap(struct ctl_table *table, int write,
> }
>
> bitmap_set(tmp_bitmap, val_a, val_b - val_a + 1);
> - first = 0;
> proc_skip_char(&p, &left, '\n');
> }
> left += skipped;
> --
> 2.11.0
>
--
Kees Cook
prev parent reply other threads:[~2020-10-05 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 20:37 [PATCH] kernel/sysctl.c: drop unneeded assignment in proc_do_large_bitmap() Sudip Mukherjee
2020-10-05 21:05 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010051404.CEE37CD617@keescook \
--to=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=mcgrof@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).