From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-hardening@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH RFT 2/3] firmware: exynos-acpm: Count number of commands in acpm_xfer
Date: Sat, 14 Feb 2026 20:13:52 +0100 [thread overview]
Message-ID: <05f0d04c-a949-455f-867f-b54d41c28c0a@kernel.org> (raw)
In-Reply-To: <20260214-firmare-acpm-counted-v1-2-32af5735470e@oss.qualcomm.com>
On 14/02/2026 13:39, Krzysztof Kozlowski wrote:
>
> if (response) {
> xfer->rxd = cmd;
> - xfer->rxlen = cmdlen;
> + xfer->rxcnt = cmdlen;
> }
> }
>
> @@ -50,7 +50,7 @@ int acpm_dvfs_set_rate(const struct acpm_handle *handle,
> u32 cmd[4];
>
> acpm_dvfs_init_set_rate_cmd(cmd, clk_id, rate);
> - acpm_dvfs_set_xfer(&xfer, cmd, sizeof(cmd), acpm_chan_id, false);
> + acpm_dvfs_set_xfer(&xfer, cmd, ARRAY_SIZE(cmd), acpm_chan_id, false);
Went fine through few build tests, but apparently there is a setup this
needs proper header (<linux/array_size.h>), as reported by kbuild robot.
There will be v2 in few days.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-14 19:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 12:39 [PATCH RFT 0/3] firmware: exynos-acpm: Use __counted_by() Krzysztof Kozlowski
2026-02-14 12:39 ` [PATCH RFT 1/3] firmware: exynos-acpm: Use unsigned int for acpm_pmic_linux_errmap index Krzysztof Kozlowski
2026-02-19 10:16 ` Tudor Ambarus
2026-02-14 12:39 ` [PATCH RFT 2/3] firmware: exynos-acpm: Count number of commands in acpm_xfer Krzysztof Kozlowski
2026-02-14 19:13 ` Krzysztof Kozlowski [this message]
2026-02-19 10:27 ` Tudor Ambarus
2026-02-19 10:31 ` Krzysztof Kozlowski
2026-02-14 12:39 ` [PATCH RFT 3/3] firmware: exynos-acpm: Count acpm_xfer buffers with __counted_by_ptr Krzysztof Kozlowski
2026-02-19 11:20 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05f0d04c-a949-455f-867f-b54d41c28c0a@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=gustavoars@kernel.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).